Draft
Conversation
Convert AIGuardSystemTests.groovy to a Java JUnit 5 test extending DDJavaSpecification, using WithConfigExtension for env injection. Add junit5/mockito test deps to the agent-aiguard module and start tracking the module in .github/g2j-migrated-modules.txt.
Convert the 58-test Spock spec into a JUnit 5 Java test extending DDJavaSpecification. Use @TableTest for tabular cases (missing keys, endpoint discovery), @MethodSource for parameterized cases that need non-tabular data (action/blocking/suite combinations, options, sds-finding shapes), and Mockito with ArgumentCaptor for the metaStruct capture pattern previously expressed as Spock closures.
Convert the AI Guard MessageWriter Spock spec to a Java JUnit 5 test extending DDJavaSpecification, replacing injectSysConfig with the @WithConfig annotation. The 8 tests cover msgpack serialization of plain content, tool calls/output, and content parts.
smola
added
comp: testing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Migrate AI Guard tests to JUnit 5, except smoke tests that require migrating several base classes.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.