Fix sql plan nodes order causing test flakiness#10911
Fix sql plan nodes order causing test flakiness#10911aboitreaud wants to merge 2 commits intomasterfrom
Conversation
|
Hi! 👋 Thanks for your pull request! 🎉 To help us review it, please make sure to:
If you need help, please check our contributing guidelines. |
BenchmarksStartupParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 63 metrics, 8 unstable metrics. Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.61.0-SNAPSHOT~4c21594126, baseline=1.61.0-SNAPSHOT~51fe2ea157
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.056 s) : 0, 1055579
Total [baseline] (8.88 s) : 0, 8879557
Agent [candidate] (1.056 s) : 0, 1056229
Total [candidate] (8.828 s) : 0, 8827552
section iast
Agent [baseline] (1.232 s) : 0, 1232170
Total [baseline] (9.589 s) : 0, 9588537
Agent [candidate] (1.225 s) : 0, 1224545
Total [candidate] (9.552 s) : 0, 9552448
gantt
title insecure-bank - break down per module: candidate=1.61.0-SNAPSHOT~4c21594126, baseline=1.61.0-SNAPSHOT~51fe2ea157
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.202 ms) : 0, 1202
crashtracking [candidate] (1.193 ms) : 0, 1193
BytebuddyAgent [baseline] (628.804 ms) : 0, 628804
BytebuddyAgent [candidate] (629.0 ms) : 0, 629000
AgentMeter [baseline] (29.348 ms) : 0, 29348
AgentMeter [candidate] (29.404 ms) : 0, 29404
GlobalTracer [baseline] (256.69 ms) : 0, 256690
GlobalTracer [candidate] (256.692 ms) : 0, 256692
AppSec [baseline] (31.739 ms) : 0, 31739
AppSec [candidate] (31.696 ms) : 0, 31696
Debugger [baseline] (59.65 ms) : 0, 59650
Debugger [candidate] (59.46 ms) : 0, 59460
Remote Config [baseline] (591.59 µs) : 0, 592
Remote Config [candidate] (597.089 µs) : 0, 597
Telemetry [baseline] (7.993 ms) : 0, 7993
Telemetry [candidate] (8.751 ms) : 0, 8751
Flare Poller [baseline] (3.516 ms) : 0, 3516
Flare Poller [candidate] (3.482 ms) : 0, 3482
section iast
crashtracking [baseline] (1.215 ms) : 0, 1215
crashtracking [candidate] (1.186 ms) : 0, 1186
BytebuddyAgent [baseline] (799.889 ms) : 0, 799889
BytebuddyAgent [candidate] (794.606 ms) : 0, 794606
AgentMeter [baseline] (11.616 ms) : 0, 11616
AgentMeter [candidate] (11.344 ms) : 0, 11344
GlobalTracer [baseline] (247.554 ms) : 0, 247554
GlobalTracer [candidate] (246.654 ms) : 0, 246654
IAST [baseline] (25.593 ms) : 0, 25593
IAST [candidate] (25.341 ms) : 0, 25341
AppSec [baseline] (26.778 ms) : 0, 26778
AppSec [candidate] (26.416 ms) : 0, 26416
Debugger [baseline] (68.818 ms) : 0, 68818
Debugger [candidate] (68.018 ms) : 0, 68018
Remote Config [baseline] (527.451 µs) : 0, 527
Remote Config [candidate] (528.554 µs) : 0, 529
Telemetry [baseline] (10.447 ms) : 0, 10447
Telemetry [candidate] (10.672 ms) : 0, 10672
Flare Poller [baseline] (3.525 ms) : 0, 3525
Flare Poller [candidate] (3.804 ms) : 0, 3804
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.61.0-SNAPSHOT~4c21594126, baseline=1.61.0-SNAPSHOT~51fe2ea157
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063803
Total [baseline] (11.072 s) : 0, 11072493
Agent [candidate] (1.063 s) : 0, 1063264
Total [candidate] (11.076 s) : 0, 11076393
section appsec
Agent [baseline] (1.254 s) : 0, 1254466
Total [baseline] (11.207 s) : 0, 11207354
Agent [candidate] (1.247 s) : 0, 1247481
Total [candidate] (11.181 s) : 0, 11180926
section iast
Agent [baseline] (1.237 s) : 0, 1236760
Total [baseline] (11.451 s) : 0, 11450684
Agent [candidate] (1.238 s) : 0, 1237719
Total [candidate] (11.338 s) : 0, 11338302
section profiling
Agent [baseline] (1.185 s) : 0, 1185020
Total [baseline] (10.993 s) : 0, 10992950
Agent [candidate] (1.185 s) : 0, 1185237
Total [candidate] (11.084 s) : 0, 11083962
gantt
title petclinic - break down per module: candidate=1.61.0-SNAPSHOT~4c21594126, baseline=1.61.0-SNAPSHOT~51fe2ea157
dateFormat X
axisFormat %s
section tracing
crashtracking [baseline] (1.201 ms) : 0, 1201
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (632.295 ms) : 0, 632295
BytebuddyAgent [candidate] (633.057 ms) : 0, 633057
AgentMeter [baseline] (29.567 ms) : 0, 29567
AgentMeter [candidate] (29.623 ms) : 0, 29623
GlobalTracer [baseline] (257.914 ms) : 0, 257914
GlobalTracer [candidate] (258.277 ms) : 0, 258277
AppSec [baseline] (31.971 ms) : 0, 31971
AppSec [candidate] (31.948 ms) : 0, 31948
Debugger [baseline] (60.805 ms) : 0, 60805
Debugger [candidate] (60.757 ms) : 0, 60757
Remote Config [baseline] (589.748 µs) : 0, 590
Remote Config [candidate] (591.568 µs) : 0, 592
Telemetry [baseline] (8.122 ms) : 0, 8122
Telemetry [candidate] (8.121 ms) : 0, 8121
Flare Poller [baseline] (5.195 ms) : 0, 5195
Flare Poller [candidate] (3.577 ms) : 0, 3577
section appsec
crashtracking [baseline] (1.195 ms) : 0, 1195
crashtracking [candidate] (1.198 ms) : 0, 1198
BytebuddyAgent [baseline] (663.613 ms) : 0, 663613
BytebuddyAgent [candidate] (658.966 ms) : 0, 658966
AgentMeter [baseline] (12.148 ms) : 0, 12148
AgentMeter [candidate] (12.092 ms) : 0, 12092
GlobalTracer [baseline] (259.345 ms) : 0, 259345
GlobalTracer [candidate] (257.952 ms) : 0, 257952
AppSec [baseline] (178.326 ms) : 0, 178326
AppSec [candidate] (177.914 ms) : 0, 177914
Debugger [baseline] (66.415 ms) : 0, 66415
Debugger [candidate] (66.191 ms) : 0, 66191
Remote Config [baseline] (636.242 µs) : 0, 636
Remote Config [candidate] (625.513 µs) : 0, 626
Telemetry [baseline] (8.412 ms) : 0, 8412
Telemetry [candidate] (8.366 ms) : 0, 8366
Flare Poller [baseline] (3.591 ms) : 0, 3591
Flare Poller [candidate] (3.648 ms) : 0, 3648
IAST [baseline] (24.405 ms) : 0, 24405
IAST [candidate] (24.266 ms) : 0, 24266
section iast
crashtracking [baseline] (1.206 ms) : 0, 1206
crashtracking [candidate] (1.2 ms) : 0, 1200
BytebuddyAgent [baseline] (802.581 ms) : 0, 802581
BytebuddyAgent [candidate] (803.458 ms) : 0, 803458
AgentMeter [baseline] (11.661 ms) : 0, 11661
AgentMeter [candidate] (11.705 ms) : 0, 11705
GlobalTracer [baseline] (248.442 ms) : 0, 248442
GlobalTracer [candidate] (249.06 ms) : 0, 249060
AppSec [baseline] (26.695 ms) : 0, 26695
AppSec [candidate] (26.69 ms) : 0, 26690
Debugger [baseline] (71.208 ms) : 0, 71208
Debugger [candidate] (70.001 ms) : 0, 70001
Remote Config [baseline] (535.055 µs) : 0, 535
Remote Config [candidate] (537.059 µs) : 0, 537
Telemetry [baseline] (9.32 ms) : 0, 9320
Telemetry [candidate] (9.763 ms) : 0, 9763
Flare Poller [baseline] (3.399 ms) : 0, 3399
Flare Poller [candidate] (3.491 ms) : 0, 3491
IAST [baseline] (25.553 ms) : 0, 25553
IAST [candidate] (25.6 ms) : 0, 25600
section profiling
ProfilingAgent [baseline] (94.073 ms) : 0, 94073
ProfilingAgent [candidate] (94.841 ms) : 0, 94841
crashtracking [baseline] (1.189 ms) : 0, 1189
crashtracking [candidate] (1.172 ms) : 0, 1172
BytebuddyAgent [baseline] (684.467 ms) : 0, 684467
BytebuddyAgent [candidate] (683.305 ms) : 0, 683305
AgentMeter [baseline] (9.002 ms) : 0, 9002
AgentMeter [candidate] (8.989 ms) : 0, 8989
GlobalTracer [baseline] (215.308 ms) : 0, 215308
GlobalTracer [candidate] (215.499 ms) : 0, 215499
AppSec [baseline] (32.181 ms) : 0, 32181
AppSec [candidate] (32.442 ms) : 0, 32442
Debugger [baseline] (65.716 ms) : 0, 65716
Debugger [candidate] (66.203 ms) : 0, 66203
Remote Config [baseline] (562.19 µs) : 0, 562
Remote Config [candidate] (564.941 µs) : 0, 565
Telemetry [baseline] (7.762 ms) : 0, 7762
Telemetry [candidate] (7.752 ms) : 0, 7752
Flare Poller [baseline] (3.524 ms) : 0, 3524
Flare Poller [candidate] (3.453 ms) : 0, 3453
Profiling [baseline] (94.627 ms) : 0, 94627
Profiling [candidate] (95.408 ms) : 0, 95408
LoadParameters
See matching parameters
SummaryFound 1 performance improvements and 2 performance regressions! Performance is the same for 18 metrics, 15 unstable metrics.
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~4c21594126, baseline=1.61.0-SNAPSHOT~51fe2ea157
dateFormat X
axisFormat %s
section baseline
no_agent (1.181 ms) : 1170, 1192
. : milestone, 1181,
iast (3.209 ms) : 3169, 3248
. : milestone, 3209,
iast_FULL (6.106 ms) : 6044, 6169
. : milestone, 6106,
iast_GLOBAL (3.697 ms) : 3636, 3757
. : milestone, 3697,
profiling (2.227 ms) : 2208, 2247
. : milestone, 2227,
tracing (1.831 ms) : 1815, 1846
. : milestone, 1831,
section candidate
no_agent (1.191 ms) : 1179, 1203
. : milestone, 1191,
iast (3.185 ms) : 3144, 3227
. : milestone, 3185,
iast_FULL (5.829 ms) : 5771, 5888
. : milestone, 5829,
iast_GLOBAL (3.608 ms) : 3549, 3666
. : milestone, 3608,
profiling (2.151 ms) : 2131, 2171
. : milestone, 2151,
tracing (1.836 ms) : 1818, 1853
. : milestone, 1836,
Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.61.0-SNAPSHOT~4c21594126, baseline=1.61.0-SNAPSHOT~51fe2ea157
dateFormat X
axisFormat %s
section baseline
no_agent (19.061 ms) : 18864, 19257
. : milestone, 19061,
appsec (19.114 ms) : 18914, 19314
. : milestone, 19114,
code_origins (17.898 ms) : 17718, 18079
. : milestone, 17898,
iast (17.782 ms) : 17605, 17958
. : milestone, 17782,
profiling (18.432 ms) : 18250, 18614
. : milestone, 18432,
tracing (18.007 ms) : 17830, 18184
. : milestone, 18007,
section candidate
no_agent (19.441 ms) : 19239, 19643
. : milestone, 19441,
appsec (18.492 ms) : 18301, 18684
. : milestone, 18492,
code_origins (17.979 ms) : 17800, 18159
. : milestone, 17979,
iast (18.044 ms) : 17864, 18224
. : milestone, 18044,
profiling (20.911 ms) : 20697, 21125
. : milestone, 20911,
tracing (17.938 ms) : 17759, 18117
. : milestone, 17938,
DacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 10 metrics, 2 unstable metrics. Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~4c21594126, baseline=1.61.0-SNAPSHOT~51fe2ea157
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (3.739 ms) : 3522, 3956
. : milestone, 3739,
iast (2.252 ms) : 2182, 2321
. : milestone, 2252,
iast_GLOBAL (2.291 ms) : 2221, 2360
. : milestone, 2291,
profiling (2.507 ms) : 2343, 2672
. : milestone, 2507,
tracing (2.074 ms) : 2020, 2129
. : milestone, 2074,
section candidate
no_agent (1.47 ms) : 1459, 1482
. : milestone, 1470,
appsec (3.763 ms) : 3541, 3985
. : milestone, 3763,
iast (2.253 ms) : 2183, 2323
. : milestone, 2253,
iast_GLOBAL (2.295 ms) : 2226, 2365
. : milestone, 2295,
profiling (2.091 ms) : 2035, 2148
. : milestone, 2091,
tracing (2.069 ms) : 2015, 2123
. : milestone, 2069,
Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.61.0-SNAPSHOT~4c21594126, baseline=1.61.0-SNAPSHOT~51fe2ea157
dateFormat X
axisFormat %s
section baseline
no_agent (15.572 s) : 15572000, 15572000
. : milestone, 15572000,
appsec (14.557 s) : 14557000, 14557000
. : milestone, 14557000,
iast (18.218 s) : 18218000, 18218000
. : milestone, 18218000,
iast_GLOBAL (17.817 s) : 17817000, 17817000
. : milestone, 17817000,
profiling (15.427 s) : 15427000, 15427000
. : milestone, 15427000,
tracing (14.897 s) : 14897000, 14897000
. : milestone, 14897000,
section candidate
no_agent (15.258 s) : 15258000, 15258000
. : milestone, 15258000,
appsec (14.742 s) : 14742000, 14742000
. : milestone, 14742000,
iast (18.472 s) : 18472000, 18472000
. : milestone, 18472000,
iast_GLOBAL (17.957 s) : 17957000, 17957000
. : milestone, 17957000,
profiling (14.872 s) : 14872000, 14872000
. : milestone, 14872000,
tracing (15.063 s) : 15063000, 15063000
. : milestone, 15063000,
|
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings. Use
The expected merge time in Use ⏳ Processing |
What Does This Do
Use LinkedHashSet instead HashSet in the Spark SQL Plan for deterministic ordering of the nodes
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.