Skip to content

Handle async join errors and skip empty capture matches#314

Draft
artslidd wants to merge 1 commit intomainfrom
artslidd/sds-async-join-empty-capture
Draft

Handle async join errors and skip empty capture matches#314
artslidd wants to merge 1 commit intomainfrom
artslidd/sds-async-join-empty-capture

Conversation

@artslidd
Copy link
Contributor

@artslidd artslidd commented Feb 5, 2026

Summary

  • return a scanner error when async rule tasks fail to join
  • skip zero-length capture-group matches to avoid panics/infinite loops
  • add tests for async join errors and empty capture groups

Testing

  • cargo test (fails in this environment: httpmock tests cannot bind to localhost; scanner::test::test_match_suppression_invalid expectation mismatch)

@artslidd artslidd requested a review from a team as a code owner February 5, 2026 11:18
@artslidd artslidd marked this pull request as draft February 5, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant