Explicitly build the babel plugin in benchmarks CI#1334
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a benchmarks CI failure by ensuring @datadog/mobile-react-native-babel-plugin is explicitly built during the benchmarks pipeline so its lib/ output exists when benchmarks/babel.config.js loads the plugin.
Changes:
- Add a CI step after the root
yarn installto run the babel plugin’spreparescript (which buildslib/viayarn bob build). - Document why this is needed with an inline comment referencing Yarn Berry behavior around
prepare.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sbarrio
approved these changes
Jul 8, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a CI failure. benchmarks/babel.config.js now loads @datadog/mobile-react-native-babel-plugin to enable SVG tracking, but yarn install doesn't actually build that package's lib/ output — Yarn Berry only runs install/postinstall automatically, not prepare, so the plugin's rm -rf lib && yarn bob build step was never executing in CI. Added an explicit build step for the plugin right after yarn install. Reproduced the exact CI error locally (Cannot find module '.../lib/commonjs/index') and confirmed this fix resolves it.
Motivation
What inspired you to submit this pull request?
Additional Notes
Anything else we should know when reviewing?
Review checklist (to be filled by reviewers)