Skip to content

Explicitly build the babel plugin in benchmarks CI#1334

Merged
jonathanmos merged 1 commit into
developfrom
jmoskovich/fix-babel-benchmark-in-ci
Jul 8, 2026
Merged

Explicitly build the babel plugin in benchmarks CI#1334
jonathanmos merged 1 commit into
developfrom
jmoskovich/fix-babel-benchmark-in-ci

Conversation

@jonathanmos

Copy link
Copy Markdown
Member

What does this PR do?

Fixes a CI failure. benchmarks/babel.config.js now loads @datadog/mobile-react-native-babel-plugin to enable SVG tracking, but yarn install doesn't actually build that package's lib/ output — Yarn Berry only runs install/postinstall automatically, not prepare, so the plugin's rm -rf lib && yarn bob build step was never executing in CI. Added an explicit build step for the plugin right after yarn install. Reproduced the exact CI error locally (Cannot find module '.../lib/commonjs/index') and confirmed this fix resolves it.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@jonathanmos jonathanmos marked this pull request as ready for review July 8, 2026 13:37
@jonathanmos jonathanmos requested a review from a team as a code owner July 8, 2026 13:37
Copilot AI review requested due to automatic review settings July 8, 2026 13:37

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a benchmarks CI failure by ensuring @datadog/mobile-react-native-babel-plugin is explicitly built during the benchmarks pipeline so its lib/ output exists when benchmarks/babel.config.js loads the plugin.

Changes:

  • Add a CI step after the root yarn install to run the babel plugin’s prepare script (which builds lib/ via yarn bob build).
  • Document why this is needed with an inline comment referencing Yarn Berry behavior around prepare.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@datadog-datadog-prod-us1-2

Copy link
Copy Markdown

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 1 Pipeline job failed

DataDog/dd-sdk-reactnative | build-and-upload:app   View in Datadog   GitLab

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 9106508 | Docs | Datadog PR Page | Give us feedback!

@jonathanmos jonathanmos merged commit 4026d41 into develop Jul 8, 2026
12 of 13 checks passed
@jonathanmos jonathanmos deleted the jmoskovich/fix-babel-benchmark-in-ci branch July 8, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants