fix(sensitive_data_scanner_rules): align name with linked standard pattern on write#627
Merged
Merged
Conversation
riyazsh
force-pushed
the
riyaz/HAMR-392-sds-name-canonical
branch
from
913b239 to
3450892
Compare
…ttern on write Destination API rejects a standard-pattern-linked rule whose name does not match the pattern's canonical name. Overwrite the name inside create/update and emit a metric when the rewrite fires.
riyazsh
force-pushed
the
riyaz/HAMR-392-sds-name-canonical
branch
from
3450892 to
891650a
Compare
michael-richey
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Destination API rejects a standard-pattern-linked SDS rule when
attributes.namedoes not match the linked pattern's canonical name, causing sync to fail on create.This aligns the name with the linked pattern's canonical name on write so create succeeds. Emits an
actionmetric (action_sub_type:standard_pattern_name_rewrite) when the rewrite fires, for auditability.Test plan
pytest tests/unit/— 928 pass.ruff checkclean.