fix(logs): format log level into correct status#1036
Open
duncanista wants to merge 4 commits intomainfrom
Open
fix(logs): format log level into correct status#1036duncanista wants to merge 4 commits intomainfrom
duncanista wants to merge 4 commits intomainfrom
Conversation
incoming logs as JSON might contain a level which we want to send as a status in datadog logs, applied to AWS JSON logs and also internal logs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Log level was not properly formatted for AWS JSON logs – same goes for our own logs where the level was not truly respected.
#807 and SVLS-8590
Testing
Unit tests and on actual resources.
Before logs with
debugappeared asinfoNow, all appear with their right level: