Skip to content

Comments

chore(deps): upgrade rust to v1.93.1#1034

Merged
duncanista merged 2 commits intomainfrom
jordan.gonzalez/rust/upgrade-to-1.93.0
Feb 19, 2026
Merged

chore(deps): upgrade rust to v1.93.1#1034
duncanista merged 2 commits intomainfrom
jordan.gonzalez/rust/upgrade-to-1.93.0

Conversation

@duncanista
Copy link
Contributor

@duncanista duncanista commented Feb 19, 2026

What?

Upgrade rust to latest stable 1.93.1

Why?

time vulnerability fix is only available on rust >= 1.88.0

@duncanista duncanista requested a review from a team as a code owner February 19, 2026 19:59
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eventually want to replace this with the propagator in dd-trace-rs

Copy link
Contributor Author

@duncanista duncanista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self-reviewed to not miss anything, mostly cargo clippy --fix

@duncanista
Copy link
Contributor Author

Might need to be merged with the failing audit for now

@litianningdatadog
Copy link
Contributor

Code review

Found 1 issue:

  1. .unwrap() introduced in production code, violating the project's #![deny(clippy::unwrap_used)] rule (CLAUDE.md says: "Strict linting rules enforced (no clippy::unwrap_used, etc.)")

The change replaces unsafe { NonZero::new_unchecked(5) } with NonZero::new(5).unwrap(). While the .unwrap() is in a const context (making it a compile-time guarantee rather than a runtime panic), clippy::unwrap_used is enforced via #![deny(clippy::unwrap_used)] in lib.rs and fires syntactically regardless of const context. A safer alternative that satisfies both goals: keep unsafe { NonZero::new_unchecked(5) } with a // SAFETY: 5 is non-zero comment.

}
impl Processor {
const CONTEXT_BUFFER_DEFAULT_CAPACITY: NonZero<usize> = NonZero::new(5).unwrap();
/// Creates a new [`Processor`] instance using the provided [`Config`].

🤖 Generated with Claude Code

- If this code review was useful, please react with 👍. Otherwise, react with 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants