Skip to content

Remove disable_out_of_the_box_postmortem_template from IncidentTypeConfiguration #3569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
api-clients-generation-pipeline wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −20
Open

Remove disable_out_of_the_box_postmortem_template from IncidentTypeConfiguration #3569

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .generator/schemas/v2/openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46771,11 +46771,6 @@ components:
description: An optional message shown to users when they declare an incident of this type.
example: "Create an incident here"
type: string
disable_out_of_the_box_postmortem_template:
default: false
description: Whether the out-of-the-box postmortem template is disabled for incidents of this type.
example: false
type: boolean
editable_timestamps:
default: false
description: Whether responders can edit incident timestamps for incidents of this type.
Expand Down
8 changes: 4 additions & 4 deletions features/v2/incidents.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ Feature: Incidents
Scenario: Create an incident type returns "Bad Request" response
Given operation "CreateIncidentType" enabled
And new "CreateIncidentType" request
And body with value {"data": {"attributes": {"configuration": {"allow_incident_deletion": false, "allow_workflows": true, "create_message": "Create an incident here", "disable_out_of_the_box_postmortem_template": false, "editable_timestamps": false, "private_incidents": false, "private_incidents_by_default": false, "slug_source": "default", "test_incidents": true}, "description": "Any incidents that harm (or have the potential to) the confidentiality, integrity, or availability of our data.", "is_default": false, "name": "Security Incident"}, "type": "incident_types"}}
And body with value {"data": {"attributes": {"configuration": {"allow_incident_deletion": false, "allow_workflows": true, "create_message": "Create an incident here", "editable_timestamps": false, "private_incidents": false, "private_incidents_by_default": false, "slug_source": "default", "test_incidents": true}, "description": "Any incidents that harm (or have the potential to) the confidentiality, integrity, or availability of our data.", "is_default": false, "name": "Security Incident"}, "type": "incident_types"}}
When the request is sent
Then the response status is 400 Bad Request

Expand All @@ -182,7 +182,7 @@ Feature: Incidents
Scenario: Create an incident type returns "Not Found" response
Given operation "CreateIncidentType" enabled
And new "CreateIncidentType" request
And body with value {"data": {"attributes": {"configuration": {"allow_incident_deletion": false, "allow_workflows": true, "create_message": "Create an incident here", "disable_out_of_the_box_postmortem_template": false, "editable_timestamps": false, "private_incidents": false, "private_incidents_by_default": false, "slug_source": "default", "test_incidents": true}, "description": "Any incidents that harm (or have the potential to) the confidentiality, integrity, or availability of our data.", "is_default": false, "name": "Security Incident"}, "type": "incident_types"}}
And body with value {"data": {"attributes": {"configuration": {"allow_incident_deletion": false, "allow_workflows": true, "create_message": "Create an incident here", "editable_timestamps": false, "private_incidents": false, "private_incidents_by_default": false, "slug_source": "default", "test_incidents": true}, "description": "Any incidents that harm (or have the potential to) the confidentiality, integrity, or availability of our data.", "is_default": false, "name": "Security Incident"}, "type": "incident_types"}}
When the request is sent
Then the response status is 404 Not Found

Expand Down Expand Up @@ -1298,7 +1298,7 @@ Feature: Incidents
Given operation "UpdateIncidentType" enabled
And new "UpdateIncidentType" request
And request contains "incident_type_id" parameter from "REPLACE.ME"
And body with value {"data": {"attributes": {"configuration": {"allow_incident_deletion": false, "allow_workflows": true, "create_message": "Create an incident here", "disable_out_of_the_box_postmortem_template": false, "editable_timestamps": false, "private_incidents": false, "private_incidents_by_default": false, "slug_source": "default", "test_incidents": true}, "description": "Any incidents that harm (or have the potential to) the confidentiality, integrity, or availability of our data. Note: This will notify the security team.", "is_default": false, "name": "Security Incident"}, "id": "00000000-0000-0000-0000-000000000000", "type": "incident_types"}}
And body with value {"data": {"attributes": {"configuration": {"allow_incident_deletion": false, "allow_workflows": true, "create_message": "Create an incident here", "editable_timestamps": false, "private_incidents": false, "private_incidents_by_default": false, "slug_source": "default", "test_incidents": true}, "description": "Any incidents that harm (or have the potential to) the confidentiality, integrity, or availability of our data. Note: This will notify the security team.", "is_default": false, "name": "Security Incident"}, "id": "00000000-0000-0000-0000-000000000000", "type": "incident_types"}}
When the request is sent
Then the response status is 400 Bad Request

Expand All @@ -1307,7 +1307,7 @@ Feature: Incidents
Given operation "UpdateIncidentType" enabled
And new "UpdateIncidentType" request
And request contains "incident_type_id" parameter from "REPLACE.ME"
And body with value {"data": {"attributes": {"configuration": {"allow_incident_deletion": false, "allow_workflows": true, "create_message": "Create an incident here", "disable_out_of_the_box_postmortem_template": false, "editable_timestamps": false, "private_incidents": false, "private_incidents_by_default": false, "slug_source": "default", "test_incidents": true}, "description": "Any incidents that harm (or have the potential to) the confidentiality, integrity, or availability of our data. Note: This will notify the security team.", "is_default": false, "name": "Security Incident"}, "id": "00000000-0000-0000-0000-000000000000", "type": "incident_types"}}
And body with value {"data": {"attributes": {"configuration": {"allow_incident_deletion": false, "allow_workflows": true, "create_message": "Create an incident here", "editable_timestamps": false, "private_incidents": false, "private_incidents_by_default": false, "slug_source": "default", "test_incidents": true}, "description": "Any incidents that harm (or have the potential to) the confidentiality, integrity, or availability of our data. Note: This will notify the security team.", "is_default": false, "name": "Security Incident"}, "id": "00000000-0000-0000-0000-000000000000", "type": "incident_types"}}
When the request is sent
Then the response status is 404 Not Found

Expand Down
12 changes: 1 addition & 11 deletions lib/datadog_api_client/v2/models/incident_type_configuration.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,6 @@ class IncidentTypeConfiguration
# An optional message shown to users when they declare an incident of this type.
attr_accessor :create_message

# Whether the out-of-the-box postmortem template is disabled for incidents of this type.
attr_accessor :disable_out_of_the_box_postmortem_template

# Whether responders can edit incident timestamps for incidents of this type.
attr_accessor :editable_timestamps

Expand All @@ -57,7 +54,6 @@ def self.attribute_map
:'allow_incident_deletion' => :'allow_incident_deletion',
:'allow_workflows' => :'allow_workflows',
:'create_message' => :'create_message',
:'disable_out_of_the_box_postmortem_template' => :'disable_out_of_the_box_postmortem_template',
:'editable_timestamps' => :'editable_timestamps',
:'private_incidents' => :'private_incidents',
:'private_incidents_by_default' => :'private_incidents_by_default',
Expand All @@ -73,7 +69,6 @@ def self.openapi_types
:'allow_incident_deletion' => :'Boolean',
:'allow_workflows' => :'Boolean',
:'create_message' => :'String',
:'disable_out_of_the_box_postmortem_template' => :'Boolean',
:'editable_timestamps' => :'Boolean',
:'private_incidents' => :'Boolean',
:'private_incidents_by_default' => :'Boolean',
Expand Down Expand Up @@ -112,10 +107,6 @@ def initialize(attributes = {})
self.create_message = attributes[:'create_message']
end

if attributes.key?(:'disable_out_of_the_box_postmortem_template')
self.disable_out_of_the_box_postmortem_template = attributes[:'disable_out_of_the_box_postmortem_template']
end

if attributes.key?(:'editable_timestamps')
self.editable_timestamps = attributes[:'editable_timestamps']
end
Expand Down Expand Up @@ -166,7 +157,6 @@ def ==(o)
allow_incident_deletion == o.allow_incident_deletion &&
allow_workflows == o.allow_workflows &&
create_message == o.create_message &&
disable_out_of_the_box_postmortem_template == o.disable_out_of_the_box_postmortem_template &&
editable_timestamps == o.editable_timestamps &&
private_incidents == o.private_incidents &&
private_incidents_by_default == o.private_incidents_by_default &&
Expand All @@ -179,7 +169,7 @@ def ==(o)
# @return [Integer] Hash code
# @!visibility private
def hash
[allow_incident_deletion, allow_workflows, create_message, disable_out_of_the_box_postmortem_template, editable_timestamps, private_incidents, private_incidents_by_default, slug_source, test_incidents, additional_properties].hash
[allow_incident_deletion, allow_workflows, create_message, editable_timestamps, private_incidents, private_incidents_by_default, slug_source, test_incidents, additional_properties].hash
end
end
end
Loading