fix: remove UsageSummaryDate models excluded by the new Ruby generator#3555
Closed
nogates wants to merge 2 commits into
Closed
fix: remove UsageSummaryDate models excluded by the new Ruby generator#3555nogates wants to merge 2 commits into
nogates wants to merge 2 commits into
Conversation
These three schemas use the x-keep-typed-in-additional-properties pattern, which surfaces typed fields through additionalProperties for forward- compatibility. The new openapi-transformer Ruby generator cannot reproduce the typed-field mirroring logic in the initialize method that this pattern requires, so it deliberately excludes these schemas rather than generating an incomplete model. Remove the model files and their Zeitwerk inflector entries so that the compatibility test can pass: our generator's output will now match the committed state of the library. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes three model files and their Zeitwerk inflector entries that the new
openapi-transformerRuby generator deliberately excludes:UsageSummaryDateUsageSummaryDateOrgUsageSummaryResponseThese schemas declare
x-keep-typed-in-additional-properties: true, which means their typed properties are also surfaced throughadditionalPropertiesfor forward-compatibility. The new generator cannot reproduce the typed-field mirroring logic ininitializethat this pattern requires (see DataDog/openapi-transformer#280), so it excludes these schemas rather than generating structurally incorrect models.Removing the files and inflector entries from the committed library state allows the compatibility test to pass: our generator's output now matches the committed state.
Review checklist
This PR includes all newly recorded cassettes for any modified tests.
This PR does not rely on API client schema changes.