🐛 Use unknown type for addReactError error parameter#4863
Merged
Conversation
|
Bundles Sizes Evolution
|
891a2fd to
7eaf6b3
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7eaf6b36f5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
thomas-lebeau
approved these changes
Jul 10, 2026
BeltranBulbarellaDD
approved these changes
Jul 10, 2026
c20cdc5 to
77ace2e
Compare
gogusarov
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
addErroralready acceptserror: unknown—addReactErrorshould match. React 19'sonUncaughtErrorcallback types the error asunknown(anything can be thrown in JS), so callingaddReactErrordirectly from it produces a type error today.Fixes #4858.
Changes
Widens the
errorparameter inaddReactErrorfromErrortounknown, aligning it with the existingaddErrorsignature. The implementation is unchanged — the cast(error as Error & { dd_context?: Context })already handles narrowing when accessing error properties.Test instructions
yarn test:unit --spec packages/browser-rum-react/src/domain/error/addReactError.spec.ts.Checklist