Consolidated #9
Open
Consolidated #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previously used data for the RDF-based package creation unit test is removed and new data is provided. The test will be updated in a forthcoming submission to use the new data. Data is also added for the folder-plus-rules-based unit test, which will also be included in the forthcoming submission.
This submission connects the command line interface (CLI) in the initial version of the AutomatePackageTool class (APT) to the functionality in the RulesEngine, RdfContentProvider and IpmPackager classes. The arguments and options in the CLI were reconciled with the requirment documents for the APT. The code for the arguments was reordered to correspond to that document. The code from the run() method on (from line 250) represents a refactoring of existing code to process parameters and metadata and new code to work with the RulesEngine and invoke the IpmPackager. It would be reasonable to ignore the code changes here and look at the new version only. In order to implement the -d option to turn debugging output on, a change was made to use the logger from ch.quos.logback rather than the one from org.springframework. This was suggested on several web sites, as the former provides a method to dynamically specify the message level for the logger to use. Separate pull requests will be needed to allow logging in other classes to participate in this level control. The code was modified to pass the requirements of CheckStyle. Numerous tab characters were removed, which explains some lines that show up in the diff but look the same. A previously committed snapshot of the eloka narwhal web site is used by the modified RdfContentProviderTest. A tree of files for the APT distributable was also added to the resources. The existing test now uses the TestPackageForCLI data set. The "package" target now produces a set of output that is close to being a distributable. It includes an executable jar file and the tree of auxiliary files, but they still need to be combined by hand to produce the final zipped distributable. The project now references the DataConservancy Maven repositories so that this project can be built in the absence of other installed DC projects.
To allow dcs-packaging-tool-cli to be built independently. The reference to the newly deployed dcs-packaging-rules artifact was also updated to use the new version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidated submissions to finish the command line packaging tool and its unit tests.