Repository navigation
Properly use zend_long when parsing parameters - #11
Merged
Merged
Conversation
Otherwise Rust might infer `i32` (4 bytes) while PHP is using `zend_long` (8 bytes), leading to PHP overwriting other memory, e.g. the next variable. This fixes the issue with the ZPP test in the demo extension having the wrong result for nullable integer parameters - the memory overwritten was the variable for marking if the integer was null or not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otherwise Rust might infer
i32(4 bytes) while PHP is usingzend_long(8 bytes), leading to PHP overwriting other memory, e.g. the next variable. This fixes the issue with the ZPP test in the demo extension having the wrong result for nullable integer parameters - the memory overwritten was the variable for marking if the integer was null or not.