Skip to content

fix: improve AI review triggering and pattern/complexity accuracy - #66

Open
DaleSeo wants to merge 3 commits into
mainfrom
fix/ai-review-ready-and-patterns
Open

fix: improve AI review triggering and pattern/complexity accuracy#66
DaleSeo wants to merge 3 commits into
mainfrom
fix/ai-review-ready-and-patterns

Conversation

@DaleSeo

@DaleSeo DaleSeo commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Onboarding PR๋“ค์˜ AI ๋ฆฌ๋ทฐ ๊ฒฐ๊ณผ๋ฅผ ๋ณด๋‹ˆ ๋ชจ๋‘ ํ‹€๋ ธ๊ณ , ์ œ draft PR์—๋Š” ์•„์˜ˆ AI ๋ฆฌ๋ทฐ๊ฐ€ ๋ถ™์ง€ ์•Š๋”๋ผ๊ณ ์š”. ์›์ธ ํŒŒ์•…์„ ํ•ด๋ณด๋‹ˆ ready_for_review ์ด๋ฒคํŠธ๋ฅผ ๋ฐ›์ง€ ์•Š์•„์„œ๋”๊ตฐ์š”. ํŒจํ„ด ๋ถ„์„์€ gpt-5-nano๊ฐ€ ํ”„๋กฌํ”„ํŠธ์˜ ํŒจํ„ด ๋ชฉ๋ก์„ ํ†ต์งธ๋กœ ๋ฒ ๊ปด ๋Œ๋ ค์ค˜๋„ ๊ฒ€์ฆ ์—†์ด ์ถœ๋ ฅํ•ด์„œ, ํŒจํ„ด์ด 16~17๊ฐœ(์ค‘๋ณต ํฌํ•จ) ์ฐํ˜”์Šต๋‹ˆ๋‹ค. ์ด์ œ ๋ชฉ๋ก์— ์—†๋Š” ์ด๋ฆ„๊ณผ ์ค‘๋ณต์€ ๋ฒ„๋ฆฌ๊ณ  ์ƒํ•œ(3๊ฐœ)์„ ๋„˜๋Š” ์‘๋‹ต์€ ๋ฏฟ์ง€ ์•Š์œผ๋ฉฐ, ํ”„๋กฌํ”„ํŠธ์—๋Š” "๋‹จ์ˆœ ์ˆœํšŒยท๋‚ด์žฅ ํ•จ์ˆ˜๋ฉด ๋นˆ ๋ฐฐ์—ด"๊ณผ "ํŒจํ„ด์ด ์—†์–ด๋„ ์˜๋„๋Œ€๋กœ ํ’€์—ˆ์œผ๋ฉด ์ผ์น˜" ๊ทœ์น™์„ ๋„ฃ์—ˆ์Šต๋‹ˆ๋‹ค. ๋ณต์žก๋„ ์ฃผ์„ ์ถ”์ถœ๋„ ๋‘ ๊ตฐ๋ฐ ๊ณ ์ณค์Šต๋‹ˆ๋‹ค. # Time O(n), Space O(1)์ฒ˜๋Ÿผ ํ•œ ์ค„์— ๋‘˜ ๋‹ค ์“ฐ๋ฉด ๊ณต๊ฐ„์ด ์‹œ๊ฐ„ ๊ฐ’์œผ๋กœ ์žกํžˆ๋˜ ๋ฌธ์ œ์™€, ํ”„๋กฌํ”„ํŠธ๊ฐ€ ํ—ˆ์šฉํ•˜๋Š” ๋Œ€๋กœ ๋ชจ๋ธ์ด ํด๋ž˜์Šค ์ค„์„ headerLine์œผ๋กœ ์ฃผ๋ฉด ํด๋ž˜์Šค ์•ˆ์ชฝ(๋ฉ”์„œ๋“œ ์œ„) ์ฃผ์„์„ ๋ชป ์ฐพ๋˜ ๋ฒ„๊ทธ์ž…๋‹ˆ๋‹ค.

@DaleSeo
DaleSeo marked this pull request as ready for review November 3, 2026 02:20
@DaleSeo
DaleSeo requested review from a team and parkhojeong as code owners November 3, 2026 02:20
@DaleSeo

DaleSeo commented Nov 3, 2026

Copy link
Copy Markdown
Member Author

@codex ๋ฆฌ๋ทฐ

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
๐Ÿ“ Code Review โœ… Completed 2026-11-03T02:22:32.504852Z 4feb4dd Manual request
โ„น๏ธ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with ๐Ÿ‘€ while any review is running, comments if it has suggestions, and reacts with ๐Ÿ‘ once all reviews finish with no findings.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. ๐Ÿš€

Reviewed commit: 4feb4dd66a

โ„น๏ธ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with ๐Ÿ‘.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

parkhojeong
parkhojeong reviewed Nov 3, 2026
View reviewed changes

@parkhojeong parkhojeong left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค!

์ด์ „ PR #65 ๋„ ์ฝ”๋“œ๋งŒ ๋ณด๊ณ  ๊ดœ์ฐฎ๋‹ค๊ณ  ์ƒ๊ฐํ–ˆ๋Š”๋ฐ ๋™์ž‘์„ ์•ˆํ•˜๋Š” ๊ตฐ์š”. ์ด๋ฒˆ PR์€ ์–ด๋–ป๊ฒŒ ํ…Œ์ŠคํŠธํ•˜์…จ๋Š”์ง€ ์—ฌ์ญค๋ด๋„ ๋ ๊นŒ์š”?

์ €์˜ ๊ฒฝ์šฐ์—” #50 ์—์„œ ํ…Œ์ŠคํŠธํ•˜๊ธฐ ์œ„ํ•ด์„œ ํ…Œ์ŠคํŠธ์šฉ organization ๊ณผ repository๋ฅผ ๋งŒ๋“ค์–ด์„œ ์‹ค์ œ๋กœ ๋™์ž‘ํ•˜๋Š” ๊ฒƒ์„ ํ™•์ธ ํ–ˆ์—ˆ๋Š”๋ฐ, ๋‹ค๋ฅธ ๊ฐ„ํŽธํ•œ ๋ฐฉ๋ฒ•์ด ์žˆ๋Š”์ง€๋„ ๊ถ๊ธˆํ•˜๋„ค์š”.

@DaleSeo

DaleSeo commented Nov 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

@parkhojeong ์˜จ๋ณด๋”ฉ ๊ธฐ๊ฐ„์— ์˜ฌ๋ผ์˜ค๋Š” PR๋“ค์ด ํ…Œ์ŠคํŠธ ์—ญํ• ์„ ์ถฉ๋ถ„ํžˆ ํ•ด์ฃผ์ง€ ์•Š์„๊นŒ์š”? ์ด์ „ PR #65 ์—์„œ ๋ฐœ์ƒํ•œ ํšŒ๊ท€๋ผ๊ธฐ ๋ณด๋‹ค๋Š” ์›๋ž˜ ์žˆ์—ˆ๋˜ ๋ฌธ์ œ๊ฐ€ ๋…ธ์ถœ๋˜๋Š” ๊ฑฐ์— ๊ฐ€๊น์Šต๋‹ˆ๋‹ค. ์•ˆ์‹ฌ์ด ์•ˆ ๋˜์‹œ๋ฉด ํ˜ธ์ •๋‹˜์ด ๋งŒ๋“œ์‹  ํ™˜๊ฒฝ์—์„œ ํ…Œ์ŠคํŠธ ํ•ด์ฃผ์‹œ๋ฉด ๋” ์ข‹๊ฒ ๋„ค์š” :)

@DaleSeo
DaleSeo requested a review from parkhojeong November 3, 2026 12:06
parkhojeong
parkhojeong reviewed Nov 4, 2026
View reviewed changes
Comment thread handlers/complexity-analysis.js
for (const literal of line.matchAll(
new RegExp(BIG_O_LITERAL_PATTERN.source, "g")
)) {
if (nearest === null || distance(literal) < distance(nearest)) {

@parkhojeong parkhojeong Nov 4, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ •ํ™•ํ•œ ๋ณต์žก๋„๋ฅผ ์ ์–ด๋„ ์ฃผ์„ ํ‘œ๊ธฐ์— ๋”ฐ๋ผ ํŒ์ •์ด ๋‹ฌ๋ผ์ง€๋„ค์š”. ๋ฌธ์ž ๊ฑฐ๋ฆฌ๋กœ ๊ฐ€์žฅ ๊ฐ€๊นŒ์šด ๋ณต์žก๋„๋ฅผ ์„ ํƒํ•˜๋ฉด์„œ ๋ฐœ์ƒํ•˜๋Š” ๋ฌธ์ œ๋ผ ์ˆ˜์ •์ด ํ•„์š”ํ•  ๊ฑฐ ๊ฐ™์Šต๋‹ˆ๋‹ค.

4feb4dd ๊ธฐ์ค€์œผ๋กœ ํ™•์ธํ•œ ํ…Œ์ŠคํŠธ PR #6์ž…๋‹ˆ๋‹ค

์ฃผ์„ ๊ธฐ๋Œ€ํ•˜๋Š” ๊ณต๊ฐ„ ๋ณต์žก๋„ ์‹ค์ œ ์ถ”์ถœ๊ฐ’
TC: O(n), SC: O(1) O(1) โŒ O(n)
Time O(n), Space O(1) O(1) โœ… O(1)

parkhojeong
parkhojeong approved these changes Nov 4, 2026
View reviewed changes

@parkhojeong parkhojeong left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ปค๋ฉ˜ํŠธ ๋‚จ๊ธด ๊ฒƒ๋งŒ ํ™•์ธ ๋ถ€ํƒ๋“œ๋ ค์š” ใ…Žใ…Ž ์˜จ๋ณด๋”ฉ ๊ธฐ๊ฐ„ ๋™์•ˆ ํ…Œ์ŠคํŠธ ํ•˜๋ฉด ๋  ๊ฑฐ ๊ฐ™์Šต๋‹ˆ๋‹ค. ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parkhojeong parkhojeong parkhojeong approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DaleSeo @parkhojeong