fix(DAK-5433): clear stale deb/rpm artifacts + enforce brew install tests#86
Merged
Merged
Conversation
…rew tests Two fixes: - publish-linux-packages.yml: rm -rf target/debian/ and target/generate-rpm/ before building. A cache hit on `target/` left the old `dakera-cli_*.deb` alongside the new `dk_*.deb`; head -1 in the publish step picked the wrong one alphabetically. Clearing ensures only the freshly-named package exists. - install-test.yml: remove continue-on-error from brew jobs now that homebrew-tap is public (DAK-5437 resolved). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
ferhimedamine
force-pushed
the
fix/dak-5433-install-test-round3
branch
from
0ae3340 to
3f3a2ab
Compare
Contributor
Author
|
Conflict resolved (commit 0ae3340). PR#85 merged while this was open — both touched install-test.yml. Resolution: kept PR#85's job removals, applied this PR's |
Contributor
Author
|
✅ CI green (6/6). PR is ready to merge. Resolves the deb/rpm stale artifact cache bug (DAK-5433). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two workflow fixes to unblock the install-test CI going fully green:
1. publish-linux-packages.yml — stale artifact cache bug
The build job caches
target/keyed onCargo.lock. WhenCargo.tomlmetadata changes butCargo.lockis unchanged, the olddakera-cli_*.debpersists intarget/debian/.cargo debproduces a newdk_*.debalongside the old file, andls *.deb | head -1picks the wrong one alphabetically.Fix:
rm -rf target/debian/andrm -rf target/generate-rpm/before building.2. install-test.yml — remove stale continue-on-error from brew jobs
dakera-ai/homebrew-tapis now public (DAK-5437). Thecontinue-on-error: truewas a temporary workaround. Now that the tap is public,brew installshould be enforced.Status after this PR
dkpackage will be correctly named after next publish@dakera-ai/dakera-mcp@0.10.8live with bin conflict resolved🤖 Generated with Claude Code