fix(DAK-5433): set deb/rpm package name to dk + fix install-test failures#84
Merged
Merged
Conversation
…ures
- Cargo.toml: add name="dk" to [package.metadata.deb] and
[package.metadata.generate-rpm] so apt/dnf package is named dk
(previously dakera-cli, causing apt install dk to fail)
- install-test.yml: fix 4 failures found in first run:
- npx: switch to npm install -g + daemon-start test (dakera-mcp has no
--version flag; it starts an MCP server)
- APT: apt install dk now correct after package rename
- brew/cargo: add continue-on-error (brew needs public tap per DAK-5437;
cargo needs crates.io publication per DAK-5436)
Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems fixed
1. apt install dk fails — package named dakera-cli
cargo-debuses the Cargo.tomlnamefield by default:dakera-cli. APT doesn't search by binary name.Fix:
name = "dk"in[package.metadata.deb]→ apt package is now nameddk.2. dnf install dk worked by accident
cargo-generate-rpmalso named the packagedakera-cli, but dnf resolves by provided binary path. Still fixed for consistency:name = "dk"in[package.metadata.generate-rpm].3. npx test: dakera-mcp has no --version flag
dakera-mcpis an MCP server that starts and connects. No--versionflag.Fix: Switch test to
npm install -g+timeout 3 dakera-mcp(exit 143 = ran OK).4. cargo install/binstall need crates.io
Both packages not published to crates.io. Added
continue-on-error: true+ tracking comment.Tracked in DAK-5436.
5. brew tests: tap is private
brew installrequires a public tap. Addedcontinue-on-error: true.Tracked in DAK-5437 (founder approval needed).
Evidence
First install-test run: https://github.com/Dakera-AI/dakera-cli/actions/runs/26229500674
🤖 Generated with Claude Code