Migrate some cl_ cvars#1974
Open
slipher wants to merge 5 commits into
Open
Conversation
Don't check for alt-tab/command-tab. The OS handles this. This seems to be a relic of SDL 1.x where it would apparently block window manager shortcuts in full-screen mode on Linux (https://stackoverflow.com/questions/14846370/how-to-create-alttab-friendly-fullscreen-programs-like-games-in-linux).
Old behavior: setting cl_noprint disables showing log message both in game, and in the drop-down console. Now cl_noprint 1 only disables the in-game messages. This seems more useful to me - you can disable unwanted messages for screenshots, but without making the logs inaccessible in the console. But cl_noprint 2 can be used for the old behavior. Also migrate the cvar.
The AVI framerate is fixed, so don't change the recording rate in response to later cl_aviFrameRate changes.
Tiny bug fix: cl_consoleFontSize was read as a float in one place but the font size is always created with an integer value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the majority of
cl_cvars to new-style cvars.Other notable changes:
cl_noprintmore useful: make it possible to disable only the in-game logging that goes over the 3d rendering without also disabling logging in the console.