-
Notifications
You must be signed in to change notification settings - Fork 66
Some improvement on the deps building #1875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Do not cross-compile pkgconfig, it is part of the cross-compilation toolchain.
4b3c13b to
b797bbc
Compare
external_deps/build.sh
Outdated
| # OpenAL requires 10.14. | ||
| export MACOSX_DEPLOYMENT_TARGET=10.14 # works with CMake | ||
| common_setup macos x86_64-apple-darwin11 | ||
| common_setup macos "x86_64-apple-macosx${MACOSX_DEPLOYMENT_TARGET}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks wrong. I've never managed to find any documentation for autotools platform strings, but for me the autodetection reports darwin24.6.0 for the last component. This tracks "Kernel version" in the system's about screen.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, actually we may just be able to use x86_64-apple-darwin without version, what we need for the version is the deployment target. That last keyword seems to be mostly random when I look around on the net: darwin<VERSION>, macosx<VERSION>, macos<VERSION>…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is explicit code for those three syntaxes in LLVM:
-
Matching
darwin*andmacos*: -
Parsing Darwin and macOS versions:
We can put either Darwin version or macOS version, and in fact it's better for us to use the macOS version since we already know it and then we don't have to search for the related Darwin version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I modified the string from macosx<VERSION> to macos<VERSION> because we're in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot to say it's not an autotools thing, but a compiler thing, autotools is very likely just reporting the output of cc -dumpmachine when we let it guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks OK then, LGTM.
Autotools does parse the strings in the config.sub script. It rejects some parts if they don't match any pattern and replaces some strings with others.
b797bbc to
faa49c0
Compare
Extracted from: