Skip to content

Conversation

@illwieckz
Copy link
Member

@illwieckz illwieckz commented Nov 26, 2025

  • Do not cross-compile pkgconfig, it is part of the cross-compilation toolchain;
  • Reword a comment because we don't build SDL with pkg-config anymore;
  • Rework the macos-amd64 setup a bit;
  • Do not build OpenAL utils.

Extracted from:

# OpenAL requires 10.14.
export MACOSX_DEPLOYMENT_TARGET=10.14 # works with CMake
common_setup macos x86_64-apple-darwin11
common_setup macos "x86_64-apple-macosx${MACOSX_DEPLOYMENT_TARGET}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks wrong. I've never managed to find any documentation for autotools platform strings, but for me the autodetection reports darwin24.6.0 for the last component. This tracks "Kernel version" in the system's about screen.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, actually we may just be able to use x86_64-apple-darwin without version, what we need for the version is the deployment target. That last keyword seems to be mostly random when I look around on the net: darwin<VERSION>, macosx<VERSION>, macos<VERSION>

Copy link
Member Author

@illwieckz illwieckz Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is explicit code for those three syntaxes in LLVM:

We can put either Darwin version or macOS version, and in fact it's better for us to use the macOS version since we already know it and then we don't have to search for the related Darwin version.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified the string from macosx<VERSION> to macos<VERSION> because we're in the future.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot to say it's not an autotools thing, but a compiler thing, autotools is very likely just reporting the output of cc -dumpmachine when we let it guess.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks OK then, LGTM.

Autotools does parse the strings in the config.sub script. It rejects some parts if they don't match any pattern and replaces some strings with others.

@illwieckz illwieckz force-pushed the illwieckz/deps-improve branch from b797bbc to faa49c0 Compare November 29, 2025 02:57
@illwieckz illwieckz merged commit fae4b19 into master Nov 29, 2025
4 checks passed
@illwieckz illwieckz deleted the illwieckz/deps-improve branch November 29, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants