DVM-V1 LED fixes #10
Merged
DVM-V1 LED fixes #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I did a review using the raw diff instead of the files changed on GitHub. You just collapsed or minimized the effect in a more sane way instead of setting all the LED states. I've not personally tested this change -- but I will take you at your word this is effective. |
gatekeep
approved these changes
Nov 12, 2025
Member
gatekeep
left a comment
gatekeep
left a comment
There was a problem hiding this comment.
Looks okay -- I misinterpreted these changes earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
ifdefsfor DVM-V1 builds to enable the FM & PTT LEDs and include them in the self test.Additionally, simplified the self test LED pattern calls & made the animation delay configurable with a define.