Skip to content

-Fix issue 1059, refactor html view to display in tabs insted of list - #6101

Open
abelc-escire wants to merge 1 commit into
DSpace:mainfrom
abelc-escire:fix/issue-1059
Open

-Fix issue 1059, refactor html view to display in tabs insted of list#6101
abelc-escire wants to merge 1 commit into
DSpace:mainfrom
abelc-escire:fix/issue-1059

Conversation

@abelc-escire

@abelc-escire abelc-escire commented Aug 17, 2026

Copy link
Copy Markdown

References

Fixes #1059.

Description

Adding a small change to Edit Group to display the forms in a Tab Group instead of a list.

Instructions for Reviewers

To test it, we need to move to Edit Group, select an item for editing, and now in the forms, instead of scrolling down to display the list of forms, it'll be available in tab sections for Edit Group, EPeople y Groups (subgroups).

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR follows all coding best practices based on the Code Conventions Guide
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@lgeggleston lgeggleston added improvement usability authorization related to authorization, permissions or groups 1 APPROVAL pull request only requires a single approval to merge ux User Experience related works labels Aug 17, 2026
@lgeggleston lgeggleston moved this to 🙋 Needs Reviewers Assigned in DSpace 11.0 Release Aug 17, 2026

@nathanmlf nathanmlf left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @abelc-escire! I've tested it on my end and the new implementation is working as expected. I've attached some screenshots below showing my tests. Great improvement to the UI!

Image Image Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge authorization related to authorization, permissions or groups improvement usability ux User Experience related works

Projects

Status: 🙋 Needs Reviewers Assigned

Development

Successfully merging this pull request may close these issues.

Group's edit page should be reviewed to ensure usability

3 participants