Fix #5672: resolve health check issue with response handling

[FrancescoMolinaro]

References

Fixes #5672

Description

Adapted response handling for health check on SSR

Instructions for Reviewers

The healthCheck() function in server.ts was migrated from axios to native fetch, but the response handling was not updated.

List of changes in this PR:

Adapted repsonse handling of healthCheck function

To test build the app in prod mode and navigate to http://localhost:4000/app/health

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[tdonohue]

👍 Thanks @FrancescoMolinaro ! I've verified this fixes the issue.

Because it looks like we removed axios from all branches (see #5347 and #5379), this likely impacts all supported versions. So, I'll try to auto-backport this to all branches.

[dspace-bot]

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-5673-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-5673-to-dspace-7_x
git switch --create backport-5673-to-dspace-7_x
git cherry-pick -x 83f68792878f442feba6e2f69fa3f0d9eaf532fe

[dspace-bot]

Successfully created backport PR for dspace-8_x:

• [Port dspace-8_x] Fix #5672: resolve health check issue with response handling #5677

[dspace-bot]

Successfully created backport PR for dspace-9_x:

• [Port dspace-9_x] Fix #5672: resolve health check issue with response handling #5678

[tdonohue]

@FrancescoMolinaro : It looks like we were only able to auto-backport this to 9.x and 8.x. I suspect the same issue exists on 7.6.x though because axios was removed there in #5379. So, if you are willing to backport this manually to 7.6.x, please feel free to assign me to the backport PR.

[FrancescoMolinaro]

Hi @tdonohue , porting created at #5684 and assigned to you, thanks for the review.