Require explicit type attribute on button elements (#4781) #5098
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Fixes #4781
Description
This PR ensures that all elements explicitly define their type attribute, preventing unintended form submissions and aligning the codebase with accessibility and HTML best practices.
Instructions for Reviewers
This PR updates multiple Angular templates to explicitly define the type attribute on all
elements. The main goal is to prevent unexpected form submissions caused by the default type="submit" behavior and to comply with the ESLint rule proposed in #4781.List of changes in this PR:
How to test / review:
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.