Skip to content

Conversation

@FrancescoMolinaro
Copy link
Contributor

References

Description

Update @4science_ng-dynamic-forms version.

Instructions for Reviewers

Run npm install and check that the metadata in the node_modules folder are corrected for the library.

List of changes in this PR:

Updated @4science_ng-dynamic-forms version.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue
Copy link
Member

tdonohue commented Feb 6, 2026

Just for the record, this appears to be the changes added to 4Science/ng-dynamic-forms between these releases: 4Science/ng-dynamic-forms@8163f7b

@tdonohue tdonohue moved this to 🙋 Needs Reviewers Assigned in DSpace 10.0 Release Feb 6, 2026
@tdonohue
Copy link
Member

tdonohue commented Feb 6, 2026

@strawburster: Since you reported this issue, would you be willing to give this a quick test to verify that it looks good on your end?

@strawburster
Copy link

strawburster commented Feb 7, 2026

Thank you @FrancescoMolinaro , the metadata looks perfect. I checked out this branch, installed the dependencies, and looked into the node_modules/@4science_ng-dynamic-forms/core/package.json and could find the link to the correct source code repository. I added one more comment I'd like to discuss about how to upgrade this dependency in the future.

@tdonohue tdonohue added this to the 10.0 milestone Feb 9, 2026
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @FrancescoMolinaro ! This looks good to me too. I also reviewed the changes made in 4Science/ng-dynamic-forms@8163f7b

As a future note, whenever we update this library, it'd be useful to link back to the changes made in the 4Science/ng-dynamic-forms project. That just makes it easier to review what changes are coming into DSpace. (That said, hopefully we'll find time to replace this library soon rather than later!)

@github-project-automation github-project-automation bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace 10.0 Release Feb 9, 2026
@tdonohue tdonohue merged commit 6abbe75 into DSpace:main Feb 9, 2026
16 checks passed
@github-project-automation github-project-automation bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace 10.0 Release Feb 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 APPROVAL pull request only requires a single approval to merge bug component: submission

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

@4science_ng-dynamic-forms wrong npm metadata.

3 participants