[DURACOM-415] fix status update for cc license

[FrancescoMolinaro]

References

• Fixes CC license status in warning with section empty and not required #4845

Description

Correct handling of CC license status update:

Instructions for Reviewers

Improved status handling for CC license section

List of changes in this PR:

Adapted CC license status handling, add tests.

To test:

Configure CC license section on a submission form, ensure the rest property cc.license.required is false.
Then open the configured submission and observe the section, the status indicator should be valid (green)

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

• My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
• My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
• My PR passes ESLint validation using npm run lint
• My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
• My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
• My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
• My PR aligns with Accessibility guidelines if it makes changes to the user interface.
• My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
• My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
• If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
• If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
• If my PR fixes an issue ticket, I've linked them together.

[nwoodward]

👍 Thanks @FrancescoMolinaro. I tested this locally and noted the fix in the CC license section's status indicator.

[tdonohue]

👍 Thanks @FrancescoMolinaro ! Code looks good and I trust the testing of @nwoodward . Also backporting to 9.x.

(As this code is different in 8.x and earlier, I think that'd require a manual port. If someone wants to backport further, I'd welcome it...but I think it's also fine to ensure this is fixed in 9.x)

[dspace-bot]

Successfully created backport PR for dspace-9_x:

• [Port dspace-9_x] [DURACOM-415] fix status update for cc license #5090