Phase 2: Expand reusedCode detection to federal npm and PyPI dependencies#126
Phase 2: Expand reusedCode detection to federal npm and PyPI dependencies#126haseebmalik18 wants to merge 2 commits into
Conversation
944d244 to
bc2a3b3
Compare
haseebmalik18
changed the title
… data and logic modules
|
Not ready for review yet |
bc2a3b3 to
4170e82
Compare
|
@natalialuzuriaga Ready for review |
sachin-panayil
left a comment
sachin-panayil
left a comment
There was a problem hiding this comment.
this is a great start. i left some general comments but before approving, i want to see this actually work and populate the reusedCode field in a repo. can you use testing-repo or any test repo to use this branch and actually show the reusedCode being detected and added?
There was a problem hiding this comment.
how was the file created? if it was manually created, i think there needs to be some documentation within the file with who made it, and an explainer and the date it was created so then if it needs to be updated in the future, we can follow a lineage. there is also a bigger question of what do we need to do if we need to regenerate/update this file but i think we can get away with it since its government repos
There was a problem hiding this comment.
This file was manually created, I am currently in talks with Natalia on the best way to automatically updating the list with new fed gov packages.
| }); | ||
| }); | ||
|
|
||
| describe("GOV_DEPENDENCIES integrity", () => { |
There was a problem hiding this comment.
we should have an integrity test for the pypi dependecies as well
2 participants
Summary
Auto-fills
code.json'sreusedCodefield with the federal dependencies detected in a repository's manifests. Phase 2 of #124.Changes
src/gov-dependencies.data.ts.package.jsonand PyPI deps fromrequirements.txt, each through its own lookup since PyPI normalizes names differently.src/gov-dependencies.data.ts.src/gov-dependencies.tskeeps the lookup logic only.