Skip to content

fix(web): harden offers explorer, share audit and value calculator (#1055) [WIP handoff] - #1096

Draft
JOY (JOY) wants to merge 3 commits into
devfrom
fix/offers-share-audit-and-value-calc-bounds
Draft

JOY (JOY) wants to merge 3 commits into
devfrom
fix/offers-share-audit-and-value-calc-bounds

Conversation

@JOY

@JOY JOY (JOY) commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Closes #1055

Draft: handoff, not ready to merge. The Antigravity "Rate" (web) agent ran out of quota mid-task. Claude Code committed its uncommitted work as-is (b53112f) so nothing is lost when JOY switches machines.

What is in it

The agent was hardening input bounds in three leaderboard components, as part of its series #1049 / #1052 / #1055:

  • ProductOffersExplorer.tsx: +71 / -23
  • ProductShareAuditButton.tsx: +58
  • ProductValueCalculator.tsx: +33. It extracts sanitizeValueCriterionScore5 (note: it now rounds the score to 1 decimal) and sanitizeValueCalcFileToken, which strips control characters and caps the token at 80 characters.
  • New cases in apps/web/src/server/rate/__tests__/core-rate-architecture.test.ts (+71), suite label [126h/135].

State

  • Base: merged with origin/dev on 2026-10-26 (Auto-fix, after refactor(shared-data): one source for the bait-price rule and price floor #1091), merge commit c0f41e4. The only conflict was the new 126h block in core-rate-architecture.test.ts, which is kept. ProductOffersExplorer.tsx merged cleanly onto @repo/shared-data/rules.
  • Tests (after the merge): pnpm --filter @repo/web typecheck, lint and test all pass locally (exit 0).
  • Review: no independent review yet.

Next steps for whoever picks this up

  1. Bring up to date with origin/dev and run the web checks: done (see State).
  2. Re-run CI on the PR head (Auto-fix watches it).
  3. Independent subagent review. Check that the 1-decimal rounding in sanitizeValueCriterionScore5 does not change visible scores or CSV output unintentionally.
  4. Mark ready, merge when green, and move fix(web): harden ProductOffersExplorer, ProductShareAuditButton, and ProductValueCalculator bounds #1055 to Done on Project [Phase 4.1] Web UI /smartphones: Bộ lọc đa tiêu chí theo 10 Field Groups (RAM, ROM, Giá, Pin, 120Hz, 5G) #9 (the claim label is agent:web).

🤖 Generated with Claude Code

JOY and others added 2 commits October 25, 2026 18:42
…IP, #1055)

Work in progress from the Antigravity "Rate" (web) agent, committed for
handoff after it ran out of quota. Covers ProductOffersExplorer,
ProductShareAuditButton and ProductValueCalculator. Its last run of
typecheck, lint and unit tests for #1055 finished, but the result was
not recorded, and no independent review has run yet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@vercel

vercel Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
rate Ready Ready Preview Oct 26, 2026 2:22am UTC

Request Review

@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…re-audit-and-value-calc-bounds

# Conflicts:
#	apps/web/src/server/rate/__tests__/core-rate-architecture.test.ts

This branch was successfully deployed

1 active deployment
Preview — c0f41e40 Deployed Oct 26, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:frontend Frontend / Next.js / UI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(web): harden ProductOffersExplorer, ProductShareAuditButton, and ProductValueCalculator bounds

1 participant