Expose full Water Data STAC API - #386
Draft
thodson-usgs wants to merge 5 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
waterdata.stacnamespace:get_catalog()andget_conformance()get_collections()andget_collection()get_items()andget_item()get_queryables()andsearch()waterdata.get_ratings()helper flat while grouping only the raw catalog operations underwaterdata.stacget_stac_*/search_stacdraft names because this API has not been released(dict, BaseMetadata)contract, namespace decision (ADR 0012), and API usage in the README, NEWS, reference docs, and a pedagogical notebookBefore this change,
waterdata.get_ratings()used only the specializedGET /stac/v0/searchpath and then downloaded rating assets. The rest of the public STAC API had nodataretrievalentry point. Internal/_mgmt/pingand/_mgmt/healthoperations are intentionally excluded because they are service operations rather than STAC capabilities.The upstream parameter named
tokenis exposed aspage_tokenand mapped back totokenon the wire, avoiding ambiguity with the package's credential-parameter guard.Validation
coverage run -m pytest tests/: 1005 passed, 12 live tests deselected; 98% coverageruff check .andruff format --check .mypy dataretrieval: 62 source filesgit diff --check