fix: use batched DB deletes with SKIP LOCKED for sandbox cleanup #739
+109
−81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the temp table approach with SELECT FOR UPDATE SKIP LOCKED to allow concurrent cleanup workers on MySQL. Each batch now: 1. Selects and locks rows 2. Deletes from S3 3. Deletes from DB Multiple workers process batches in parallel within a single call, and multiple instances of clean_sandboxes can also run concurrently. This distributes the DB load across smaller batches instead of one large delete at the end.
Member
Author
|
I've hotfixed this in LHCb and it seems to be working well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace temp table approach with SELECT FOR UPDATE SKIP LOCKED for sandbox cleanup. Process batches in parallel with configurable max_workers (default 10). Delete from S3 first, then DB (orphaned DB records cleaned up on next run). Distributes DB load across smaller batches instead of one large delete at the end.