chore: fix flaky parallel test for good? #91
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aldbr
force-pushed
the
fix_flaky-test-for-good-i-hope
branch
from
9160723 to
d80dbe5
Compare
aldbr
force-pushed
the
fix_flaky-test-for-good-i-hope
branch
from
d80dbe5 to
b809b6f
Compare
AcquaDiGiorgio
approved these changes
Jan 27, 2026
Collaborator
AcquaDiGiorgio
left a comment
AcquaDiGiorgio
left a comment
There was a problem hiding this comment.
Looks good to me.
Just to be a little picky, I would put the specific parallel test functions (read_interval and overlaps) inside of the tests itself, just because they won't ever be used for other tests.
Otherwise, let's hope this never fails again, it looks like a really good solution.
aldbr
force-pushed
the
fix_flaky-test-for-good-i-hope
branch
from
52182d7 to
80570a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #74
Before being merged, I need to open an issue for associating a given output sandbox to a job: https://github.com/DIRACGrid/dirac-cwl/compare/fix_flaky-test-for-good-i-hope?expand=1#diff-88189839261917680737ea6bc2d951e1231c6d3d3b07195b858e77ba1fb31ec3R278
Trying to fix the flaky test, and fixing a few minor issue with the local sandbox store.