Skip to content

fix: switch InputDataAgent from FileCatalogClient to FileCatalog - #8757

Open
maxnoe wants to merge 1 commit into
DIRACGrid:integrationfrom
maxnoe:input-data-agent-file-catalog
Open

maxnoe wants to merge 1 commit into
DIRACGrid:integrationfrom
maxnoe:input-data-agent-file-catalog

Conversation

@maxnoe

@maxnoe maxnoe commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

BEGINRELEASENOTES
*TransformationSystem
FIX: The InputDataAgent now uses FileCatalog instead of FileCatalogClient, enabling its use with any configured FileCatalog, e.g. the RucioFileCatalog.
ENDRELEASENOTES

Closes #8752

self.log.verbose("Using input data query for transformation", "%d: %s" % (transID, str(inputDataQuery)))
start = time.time()
mdc = self.metadataClient
if self.multiVO:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fstagni The multi-vo case I am very unsure about if this is the correct way to deal with it, but there seems to be no way to pass delegateDN / delegatedGroup through the FileCatalog

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andresailer or @atsareg can you answer?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if there is a way to delegate to the FileCatalog like there is for the FileCatalogClient.
On existing possibility might be to call the function in a UserProxy block ?
https://dirac.diracgrid.org/en/integration/CodeDocumentation/Core/Utilities/Proxy.html#DIRAC.Core.Utilities.Proxy.UserProxy
But that is overkill since no proxy is needed.

Maybe one needs to program the possibility to delegate into the FileCatalog?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, actually, since this code was for multiVO metadata (#7683), just passing the vo to the FileCatalog is maybe sufficient?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for having a look.

just passing the vo to the FileCatalog is maybe sufficient?

Ok, so the current solution here should be fine?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asking @martynia or @marianne013 since they are using the multiVO metadata.
is this FileCatalog(vo="myVO") instance enough to use the multiVO metadata?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: InputDataAgent always uses FileCatalogClient

3 participants