refactor: improve PilotStatusAgent performances and refactor duplicated code#8569
Open
aldbr wants to merge 2 commits into
Open
refactor: improve PilotStatusAgent performances and refactor duplicated code#8569aldbr wants to merge 2 commits into
aldbr wants to merge 2 commits into
Conversation
Contributor
Author
|
Tested in LHCb, seems to work fine. |
1 task
aldbr
force-pushed
the
fix-pilotstatusagent-ssh-leak
branch
4 times, most recently
from
d2d2ac7 to
eff200b
Compare
aldbr
force-pushed
the
fix-pilotstatusagent-ssh-leak
branch
from
eff200b to
01d0a8c
Compare
Contributor
|
Just fix |
aldbr
force-pushed
the
fix-pilotstatusagent-ssh-leak
branch
from
619ec79 to
d35f6a7
Compare
fstagni
reviewed
Jun 9, 2026
| except Exception as e: | ||
| self.log.warn("Failed to close SSH gateway connection", str(e)) | ||
|
|
||
| def shutdown(self): |
Contributor
There was a problem hiding this comment.
JobAgent and PushJobAgent are calling the shutdown method for the (inner) computing elements, which effectively before this PR is defined only for PoolComputingElement. There is seemingly no overlap, but just pointing out that this the same method signature.
| gateway = getattr(connection, "gateway", None) | ||
| try: | ||
| connection.close() | ||
| except Exception as e: # a close failure must not break cache eviction |
| if isinstance(gateway, Connection): | ||
| try: | ||
| gateway.close() | ||
| except Exception as e: |
| return | ||
| try: | ||
| cached["CE"].shutdown() | ||
| except Exception as e: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGINRELEASENOTES
*WorkloadManagement
CHANGE: improve PilotStatusAgent performances and refactor duplicated code
ENDRELEASENOTES