Skip to content

References to non-existing files #5755

Open
DFHack/scripts
#1626

Description

@chdoc

While working on #5752 (or rather DFHack/scripts#1570) I noticed that there are several locations that reference files that are, as far as I can tell, not part of the install set:

Activity

  1. ab9rf commented on Apr 4, 2026

    @ab9rf
    Member

    Quickstart.txt is present at $HACKPATH/docs/docs/Quickstart.txt in release deployments; building it is gated by the BUILD_DOCS CMake define which is normally off for deployment builds (mostly to reduce build time for devs) but on for release builds.

    I can't find any evidence that anything has ever been deployed at $HACKPATH/data/quickfort/aliases-common.txt.

  2. Alistair-Afton commented on Sep 16, 2026

    @Alistair-Afton
    Contributor

    I looked into both references.

    hack/docs/docs/Quickstart.txt is indeed present in installations, as ab9rf noted, and quickstart-guide already handles a missing file gracefully with pcall(io.lines). No fix needed there.

    hack/data/quickfort/aliases-common.txt is a different story: the only code that loads it is internal/quickfort/aliases.lua, which is reachable exclusively through internal/quickfort/config.lua and internal/quickfort/query.lua. Both of those implement the query/config blueprint modes that were retired in the v50 rewrite. parse_modeline() maps #query and #config modelines to ignore, so none of that code can run anymore. The file reference was dead code rather than a missing asset.

    Opened DFHack/scripts#1626 to remove the unreachable modules (and their equally dormant unit tests) instead of restoring a file nothing can read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions