Skip to content

Load Azure App Config outside development - #43

Merged
paulcustance-al merged 3 commits into
mainfrom
feature/load-app-config-outside-development
Sep 21, 2026
Merged

Load Azure App Config outside development#43
paulcustance-al merged 3 commits into
mainfrom
feature/load-app-config-outside-development

Conversation

@paulcustance-al

@paulcustance-al paulcustance-al commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

SAB-159

KianW-DfE
KianW-DfE previously approved these changes Sep 21, 2026
View reviewed changes
@github-actions

github-actions Bot commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Summary

Summary
Generated on: 09/21/2026 - 12:40:04
Parser: MultiReport (5x Cobertura)
Assemblies: 4
Classes: 48
Files: 42
Line coverage: 72.1% (453 of 628)
Covered lines: 453
Uncovered lines: 175
Coverable lines: 628
Total lines: 1409
Branch coverage: 63.1% (96 of 152)
Covered branches: 96
Total branches: 152
Method coverage: Feature is only available for sponsors
Tag: 182_35600759068

Coverage

SchoolAccount.Collect.Api - 71.4%
Name Line Branch
SchoolAccount.Collect.Api 71.4% 58.5%
Program 95.2% 83.3%
SchoolAccount.Collect.Api.DependencyInjection 100% 100%
SchoolAccount.Collect.Api.Endpoints.Census.GetCensusActions.GetCensusAction
sEndpoint		 100% 100%
SchoolAccount.Collect.Api.Endpoints.Census.GetCensusActions.GetCensusAction
sRequest		 100%
SchoolAccount.Collect.Api.Endpoints.Organisations.GetByLaestab.GetByLaestab
Endpoint		 100% 100%
SchoolAccount.Collect.Api.Endpoints.Shared.User 100% 75%
SchoolAccount.Collect.Api.Endpoints.Status.GetStatuses.GetStatusesEndpoint 100% 100%
SchoolAccount.Collect.Api.Endpoints.Status.GetStatuses.GetStatusesRequest 100% 100%
SchoolAccount.Collect.Api.Extensions.ConfigurationExtensions 0% 0%
SchoolAccount.Collect.Api.Extensions.EndpointExtensions 100% 92.8%
SchoolAccount.Collect.Api.Extensions.MiddlewareExtensions 100%
SchoolAccount.Collect.Api.Extensions.ResultExtensions 50% 25%
SchoolAccount.Collect.Api.Infrastructure.CustomResults 0% 0%
SchoolAccount.Collect.Api.Infrastructure.GlobalExceptionHandler 8.3%
SchoolAccount.Collect.Api.Middleware.RequestContextLoggingMiddleware 100% 100%
SchoolAccount.Collect.Application - 85.2%
Name Line Branch
SchoolAccount.Collect.Application 85.2% 87.5%
SchoolAccount.Collect.Application.Abstractions.Behaviors.LoggingDecorator.C
ommandBaseHandler		 0% 0%
SchoolAccount.Collect.Application.Abstractions.Behaviors.LoggingDecorator.C
ommandBaseHandler		 0%
SchoolAccount.Collect.Application.Abstractions.Behaviors.LoggingDecorator.C
ommandHandler<TCommand, TResponse>		 0% 0%
SchoolAccount.Collect.Application.Abstractions.Behaviors.LoggingDecorator.C
ommandHandler<TCommand, TResponse>		 0%
SchoolAccount.Collect.Application.Abstractions.Behaviors.LoggingDecorator.Q
ueryHandler<TQuery, TResponse>		 0% 0%
SchoolAccount.Collect.Application.Abstractions.Behaviors.LoggingDecorator.Q
ueryHandler<TQuery, TResponse>		 0%
SchoolAccount.Collect.Application.Census.GetCensusActions.CensusActionsResp
onse		 100%
SchoolAccount.Collect.Application.Census.GetCensusActions.CensusReturn 100%
SchoolAccount.Collect.Application.Census.GetCensusActions.GetCensusActionsH
andler		 100% 100%
SchoolAccount.Collect.Application.Census.GetCensusActions.GetCensusActionsQ
uery		 100%
SchoolAccount.Collect.Application.Census.GetCensusActions.StubbedCensusResp
onse		 100% 100%
SchoolAccount.Collect.Application.Configuration.CensusSettingsValidator 100% 100%
SchoolAccount.Collect.Application.DependencyInjection 100% 100%
SchoolAccount.Collect.Application.Organisations.GetByLaestab.GetOrganisatio
nByLaestabQuery		 100%
SchoolAccount.Collect.Application.Organisations.GetByLaestab.GetOrganisatio
nByLaestabQueryHandler		 100%
SchoolAccount.Collect.Application.Organisations.GetByLaestab.LaestabValue 100% 100%
SchoolAccount.Collect.Application.Organisations.GetByLaestab.StatusCalculat
or		 100% 100%
SchoolAccount.Collect.Application.Shared.UserDetails 100%
SchoolAccount.Collect.Application.Status.GetStatuses.GetStatusesQuery 100%
SchoolAccount.Collect.Application.Status.GetStatuses.GetStatusesQueryHandle
r		 100% 100%
SchoolAccount.Collect.Application.Status.GetStatuses.GetStatusesRequestMode
l		 100%
SchoolAccount.Collect.Application.Status.GetStatuses.OrganisationResponse 100%
SchoolAccount.Collect.Application.Status.GetStatuses.OrgDetails 100% 100%
SchoolAccount.Collect.Application.Status.GetStatuses.ReturnStatusMapper 100% 100%
SchoolAccount.Collect.Application.Status.GetStatuses.StatusResponse 100%
SchoolAccount.Collect.Application.Status.GetStatuses.StatusResponseBuilder 100% 100%
SchoolAccount.Collect.Infrastructure - 20.3%
Name Line Branch
SchoolAccount.Collect.Infrastructure 20.3% 16.6%
SchoolAccount.Collect.Infrastructure.Census.CensusReturnStatusReader 13.7% 16.6%
SchoolAccount.Collect.Infrastructure.DependencyInjection 100%
SchoolAccount.Collect.Infrastructure.Time.DateTimeProvider 0%
SchoolAccount.Collect.SharedKernel - 65.7%
Name Line Branch
SchoolAccount.Collect.SharedKernel 65.7% 31.2%
SchoolAccount.Collect.SharedKernel.Error 73.3%
SchoolAccount.Collect.SharedKernel.Result 54.5% 50%
SchoolAccount.Collect.SharedKernel.Result 80% 25%
SchoolAccount.Collect.SharedKernel.ValidationError 0% 0%

@github-actions

github-actions Bot commented Sep 21, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

77 tests  ±0   77 ✅ ±0   7s ⏱️ +2s
 5 suites ±0    0 💤 ±0 
 5 files   ±0    0 ❌ ±0 

Results for commit d163e7e. ± Comparison against base commit ab431fa.

♻️ This comment has been updated with latest results.

@paulcustance-al
Toggle Azure App Config with a setting
d163e7e 
Replaces the environment name checks with AzureAppConfiguration:Enabled.
On by default, off in Development, and any environment can flip it
without a code change.
@paulcustance-al paulcustance-al mentioned this pull request Sep 21, 2026
Merged
KianW-DfE
KianW-DfE approved these changes Sep 21, 2026
View reviewed changes

@KianW-DfE KianW-DfE left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulcustance-al
paulcustance-al merged commit eb7af68 into main Sep 21, 2026
2 checks passed
@paulcustance-al
paulcustance-al deleted the feature/load-app-config-outside-development branch September 21, 2026 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KianW-DfE KianW-DfE KianW-DfE approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paulcustance-al @KianW-DfE