Reuse #43
Open
Reuse #43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 17, 2020 14:40
Some guidance that was to inform a particular discussion that was happening some time ago, which may be useful.
irisfaraway
approved these changes
Jan 20, 2020
Member
irisfaraway
left a comment
irisfaraway
left a comment
There was a problem hiding this comment.
I really like this - having a common taxonomy for reuse is useful, and the structure makes it easy to read.
If we iterate, it might be useful to have a little more detail in some examples, so somebody who isn't familiar with a particular service or tool (eg Flood Risk Activity Exemptions) still knows how it applies.
Maybe also a quick link to the Rule of Three for those of us who haven't read Refactoring (I know, shame, shame!)
Contributor
|
Wise words, but is this a standard or guidance, or guidance that might eventually drive standards? Don't know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some guidance that was to inform a particular discussion that was happening some time ago, which may be useful.
Or, it may not. This PR is to discuss it.