Skip to content

fix/df-973: Handles invalid unicode in email fields#363

Merged
jbarnsley10 merged 5 commits intomainfrom
fix/df-973-unicode-email
Apr 15, 2026
Merged

fix/df-973: Handles invalid unicode in email fields#363
jbarnsley10 merged 5 commits intomainfrom
fix/df-973-unicode-email

Conversation

@jbarnsley10
Copy link
Copy Markdown
Contributor

@jbarnsley10 jbarnsley10 commented Apr 13, 2026

Proposed change

Shows a validation error if an email address is entered that contains invalid (unicode) characters. A specific error message is shown (rather than the generic 'wrong format') so a user can determine that for example the type of dash is incorrect.

This PR will need a model bump of defra/forms-model once the designer PR has been merged DEFRA/forms-designer#1378

Jira ticket: DF-973DF-973

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Misc. (documentation, build updates, etc)

Checklist

  • You have executed this code locally and it performs as expected.
  • You have added tests to verify your code works.
  • You have added code comments and JSDoc, where appropriate.
  • There is no commented-out code.
  • You have added developer docs in README.md and docs/* (where appropriate, e.g. new features).
  • The tests are passing (npm run test).
  • The linting checks are passing (npm run lint).
  • The code has been formatted (npm run format).

@jbarnsley10 jbarnsley10 marked this pull request as ready for review April 14, 2026 07:16
@sonarqubecloud
Copy link
Copy Markdown

@jbarnsley10 jbarnsley10 merged commit 88dbcbb into main Apr 15, 2026
23 checks passed
@jbarnsley10 jbarnsley10 deleted the fix/df-973-unicode-email branch April 15, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants