NI-119 & NI-121 & NI-124 meteoalarm v2 support #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teddmason
changed the title
teddmason
force-pushed
the
feature/NI-119-v2
branch
from
ca399be to
58db69e
Compare
teddmason
force-pushed
the
feature/NI-119-v2
branch
from
2c7dbe4 to
7381dd4
Compare
teddmason
changed the title
teddmason
force-pushed
the
feature/NI-119-v2
branch
from
7381dd4 to
0d27c00
Compare
…sage Sonarcloud stuff sonarcloud removing file Initial work to support /v2 endpoint Sonarcloud fixes v2 endpoint unit tests WIP | broken WIP WIP, fixed older tests, new test coverage required sonarcloud fixes fixing depedencies for security reverting debug settings sonarcloud message model tests Unit test coverage for message model, and adding in instructions field for v2 additional unit tests to cover processMessage sonarcloud refactoring some unit tests for getmessage and getMessagesAtom returning some basic tests for getmessage and getmessages lambda functions alligning localstack request-templates with aws remote package update2 some review fixes couple of bits missed for node v22 fixing node v22.x in package security audit fix updating node v22 in github actions
teddmason
force-pushed
the
feature/NI-119-v2
branch
from
0d27c00 to
5bcc7d7
Compare
pwadmore-ea
requested changes
Nov 18, 2025
Contributor
pwadmore-ea
left a comment
pwadmore-ea
left a comment
There was a problem hiding this comment.
docker/.env - Please change the NODEJS_VERSION environment variable from 20 to 22.
Member
Author
|
@pwadmore-ea all code review comments actioned, thank you |
pwadmore-ea
previously approved these changes
Nov 19, 2025
…to be treated same as severe, unknown to be rejected
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.