Skip to content

Conversation

@hunghaoti
Copy link
Collaborator

No description provided.

@hunghaoti hunghaoti requested a review from yingjerkao November 29, 2025 11:41
@codecov
Copy link

codecov bot commented Nov 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.34%. Comparing base (22f340d) to head (1769402).
⚠️ Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #722      +/-   ##
==========================================
+ Coverage   32.15%   32.34%   +0.19%     
==========================================
  Files         215      215              
  Lines       36281    36367      +86     
  Branches    14563    14598      +35     
==========================================
+ Hits        11667    11764      +97     
+ Misses      22685    22663      -22     
- Partials     1929     1940      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@IvanaGyro IvanaGyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why the API was commented out and is added back now? Can you mention the reason in the commit message?

@yingjerkao
Copy link
Collaborator

Why the API was commented out and is added back now? Can you mention the reason in the commit message?

I have the same question.

@hunghaoti
Copy link
Collaborator Author

Hi @chiamin and all. I found that this API getOptimalOrder() has been comment at the commit 4660bfd. We add the API getOrder and setOrder at that time, so we can use setOrder(optimal = Ture) directly and then use getOrder(), rather than using getOptimalOrder().
So I think we can close this PR without any change.

@IvanaGyro
Copy link
Collaborator

Hi @chiamin and all. I found that this API getOptimalOrder() has been comment at the commit 4660bfd. We add the API getOrder and setOrder at that time, so we can use setOrder(optimal = Ture) directly and then use getOrder(), rather than using getOptimalOrder(). So I think we can close this PR without any change.

We can remove the commented code if it has been replaced with other APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants