Skip to content

Conversation

@hunghaoti
Copy link
Collaborator

pybind11>=3.0.0 is required after PR #672 .

@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.10%. Comparing base (4d95705) to head (29af7f3).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #720      +/-   ##
==========================================
+ Coverage   31.99%   32.10%   +0.11%     
==========================================
  Files         215      215              
  Lines       36192    36218      +26     
  Branches    14520    14540      +20     
==========================================
+ Hits        11578    11627      +49     
+ Misses      22713    22668      -45     
- Partials     1901     1923      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@IvanaGyro IvanaGyro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel we should not install build tools and dependencies in CMake as possible. Doing that makes dependencies hard to be maintained and all new contributors may make mistake easily. Currenctly, including CMake files, there are three places declaring pybind11 dependency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants