Use TARGET_DIRECTORY for Kron.cpp CUDA property #710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building
src/linalg/Kron.cppfor GPU should be handled bynvcc(or another CUDA-family compiler).However, under the current configuration, the
LANGUAGE CUDAproperty does not propagate to the top-level CMake configuration, causing the file to be compiled incorrectly with a C++ compiler such asg++.This PR corrects the issue by using
TARGET_DIRECTORY, enablingKron.cppto be built properly withnvcc.This fix may also resolve the ordering issue mentioned in the comment.