Skip to content

ci: correct not safe reference - #178

Merged
guitarrapc merged 1 commit into
mainfrom
ci
Oct 7, 2026
Merged

guitarrapc merged 1 commit into
mainfrom
ci

Conversation

@guitarrapc

@guitarrapc guitarrapc commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

detected via seiton

.github/workflows/build-natives.yaml
  .github/workflows/build-natives.yaml:515:60: error [run-secrets-context-direct-use] run script must not reference ${{ secrets.* }} directly; map secrets to env and use shell variables instead (e.g. ${TOKEN}, $TOKEN, or $env:TOKEN)
Error: Process completed with exit code 1.

@guitarrapc
guitarrapc requested a review from mayuki as a code owner October 7, 2026 07:08
Copilot AI balanced review requested due to automatic review settings October 7, 2026 07:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The focused workflow change correctly resolves the reported secret-context violation without altering behavior.

Review effort: Balanced
Findings: None

What changed in this PR

Moves the GitHub token from direct script interpolation into a step environment variable, satisfying the workflow security check.

Changes:

  • Maps secrets.GITHUB_TOKEN to env.GITHUB_TOKEN.
  • Uses the shell variable when configuring the authenticated Git remote.
File Description
.github/​workflows/​build-natives.yaml Safely exposes the token to the Git command through the environment.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@guitarrapc
guitarrapc merged commit d613d5e into main Oct 7, 2026
20 checks passed
@guitarrapc
guitarrapc deleted the ci branch October 7, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants