Repository navigation
Keep certificate verification callback until native context disposal - #176
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The lifetime change aligns callback ownership with native context retention and is covered by a focused regression test.
Review effort: Balanced
Findings: None
What changed in this PR
Retains certificate-verification callbacks for the native context lifetime, preventing active TLS requests from accessing released managed callbacks.
Changes:
- Transfers callback ownership to
YahaContextSafeHandle. - Releases the callback after native context disposal.
- Adds an isolated disposal-during-handshake regression test.
| File | Description |
|---|---|
src/YetAnotherHttpHandler/YahaSafeHandles.cs |
Manages callback lifetime with the native context. |
src/YetAnotherHttpHandler/NativeHttpHandlerCore.cs |
Assigns callback ownership to the safe handle. |
test/YetAnotherHttpHandler.Test/CertificateVerificationCallbackLifetimeTest.cs |
Verifies callback retention during an active handshake. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR extends the lifetime of the certificate verification callback until the handler is disposed.
This is similar to the fix in #171, but since it does not stop callback invocations on the Rust side, it is not intended as a general fix for crashes.