feat: populate component.authors from pyproject.toml, Poetry manifests and packaging metadata - #1096
Draft
SemyonAndreyev wants to merge 2 commits into
Draft
feat: populate component.authors from pyproject.toml, Poetry manifests and packaging metadata#1096SemyonAndreyev wants to merge 2 commits into
SemyonAndreyev wants to merge 2 commits into
Conversation
…s and packaging metadata Fixes CycloneDX#648. Adds the structured, repeatable `components[].authors` (CycloneDX 1.6+) and derives the legacy singular `components[].author` string for the single-author case, from three independent sources: - PEP 621 `project.authors` (pep621.py) -- tables of name/email, with lenient handling of the non-compliant-but-real-world "Name <email>" string form some pyproject.toml files use here instead. - Poetry's `tool.poetry.authors` (utils/poetry.py) -- "Name <email>" strings. - Packaging core-metadata's `Author`/`Author-email` (utils/packaging.py, wired into the environment scan) -- the two are independent free-text fields with no guaranteed correlation when either holds more than one person; see the docstring of `metadata2authors()` for the rules used to combine or keep them separate. New shared helper module `utils/contact.py`: - `person_string2contact()` parses the "Name <email>" convention used by both Poetry and packaging metadata. - `contacts2author()` derives the legacy `author` string only when there is exactly one author -- CycloneDX has no agreed-upon way to fold multiple authors into one string (see CycloneDX/specification#335), so this deliberately does not guess a join convention. Found and worked around a real footgun in `email.utils.getaddresses()`: fed a bare name with no `@`, it silently mis-splits on whitespace and keeps only the last word (`getaddresses(['Jane Doe']) == [('', 'Jane')]`). `metadata2authors()` filters out any parsed address that doesn't actually contain `@` before trusting it. Tests: 56 new cases across a new `test_utils_contact.py`, new `test_utils_poetry.py`, new `test_utils_packaging.py`, and an extended `test_utils_pep621.py` -- covering both happy paths and the edge cases above. Full existing suite passes unchanged aside from the expected snapshot updates (root components in fixtures that declare authors now show them). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015xJ8pA9rPpAjVATkZCzCS2 Signed-off-by: Semyon Andreev <q2quantum.app@gmail.com>
Not up to standards ⛔🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
…ting Additional test coverage for the component.authors feature (CycloneDX#1096/CycloneDX#648), found by systematically probing edge cases of the three author sources: - contact.py: `_PERSON_STRING_MATCHER.match()` returning None was marked `# pragma: nocover -- the pattern matches any string, including the empty one`, but that comment is incorrect -- multiple `<...>` fragments, an unbalanced bracket, or trailing text after a closing `>` all make the whole match fail (verified live). Removed the stale pragma, documented why the branch is reachable, and added 5 new test cases exercising it (test_none_for_unparseable_shape). - pep621.py: `project2authors()` already tolerates a not-per-spec *string* entry in `authors` (see test_project2authors_string_entry_not_per_spec_ but_tolerated), but a non-dict, non-string entry -- e.g. `authors = [123]`, valid TOML, invalid PEP 621 -- crashed with AttributeError on `author.get(...)`. Verified live before fixing. Now skipped, consistent with the function's own existing "be lenient, don't crash" intent for the string case; 3 new test cases. - poetry.py: same class of bug in `poetry2authors()` -- a non-string entry crashed with TypeError from `re.match()` inside `person_string2contact()`. Same fix, same reasoning; 3 new test cases. metadata2authors() in packaging.py was also checked for a similar gap but already has thorough dedicated coverage matching its own documented rules (9 existing tests); no gap found there. 68/68 tests pass across the 4 affected test modules (11 new cases added). flake8 and mypy clean on all changed files. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015xJ8pA9rPpAjVATkZCzCS2 Signed-off-by: Semyon Andreev <q2quantum.app@gmail.com>
Author
|
Pushed a follow-up commit while stress-testing this feature's edge cases further: found and fixed two real crashes on not-per-spec (but valid TOML)
Both are now skipped, consistent with this same code's existing "be lenient, don't crash" handling of a not-per-spec string entry in the PEP 621 case. Also removed a stale 11 new test cases, 68/68 passing across the 4 affected test modules. |
There was a problem hiding this comment.
🟡 Changes recommended
One or more issues must be addressed before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds structured and legacy component author metadata from PEP 621, Poetry, and package metadata.
Changes:
- Adds shared contact parsing and legacy-author derivation.
- Wires authors into manifest and environment components.
- Adds tests and updates generated SBOM snapshots.
File summaries
| File | Description |
|---|---|
| tests/_data/snapshots/poetry/some-groups_group-deps_lock21_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-groups_group-deps_lock21_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-groups_group-deps_lock21_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-groups_group-deps_lock21_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-groups_group-deps_lock20_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-groups_group-deps_lock20_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-groups_group-deps_lock20_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-groups_group-deps_lock20_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-groups_group-deps_lock11_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-groups_group-deps_lock11_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-groups_group-deps_lock11_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-groups_group-deps_lock11_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-extras_with-extras_lock21_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-extras_with-extras_lock21_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-extras_with-extras_lock21_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-extras_with-extras_lock21_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-extras_with-extras_lock20_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-extras_with-extras_lock20_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-extras_with-extras_lock20_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-extras_with-extras_lock20_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-extras_with-extras_lock11_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-extras_with-extras_lock11_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-extras_with-extras_lock11_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-extras_with-extras_lock11_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-extras_with-extras_lock10_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-extras_with-extras_lock10_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-extras_with-extras_lock10_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/some-extras_with-extras_lock10_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock21_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock21_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock21_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock21_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock21_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock21_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock21_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock21_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock20_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock20_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock20_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock20_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock20_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock20_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock20_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock20_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock11_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock11_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock11_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock11_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock11_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock11_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock11_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock11_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock10_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock10_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock10_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock10_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock10_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock10_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock10_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-urls_lock10_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-optionals-no-extra_lock21_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-optionals-no-extra_lock21_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-optionals-no-extra_lock21_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-optionals-no-extra_lock21_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-optionals-no-extra_lock20_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-optionals-no-extra_lock20_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-optionals-no-extra_lock20_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-optionals-no-extra_lock20_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-optionals-no-extra_lock11_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-optionals-no-extra_lock11_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-optionals-no-extra_lock11_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-optionals-no-extra_lock11_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-optionals-no-extra_lock10_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-optionals-no-extra_lock10_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-optionals-no-extra_lock10_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-optionals-no-extra_lock10_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock21_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock21_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock21_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock21_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock21_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock21_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock21_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock21_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock20_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock20_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock20_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock20_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock20_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock20_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock20_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock20_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock11_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock11_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock11_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock11_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock11_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock11_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock11_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock11_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock10_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock10_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock10_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock10_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock10_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock10_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock10_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_with-extras_lock10_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue727_lock21_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue727_lock21_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue727_lock21_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue727_lock21_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue727_lock20_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue727_lock20_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue727_lock20_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue727_lock20_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue702_lock21_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue702_lock21_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue702_lock21_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue702_lock21_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue702_lock20_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue702_lock20_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue702_lock20_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue702_lock20_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue702_lock11_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue702_lock11_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue702_lock11_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue702_lock11_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue702_lock10_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue702_lock10_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue702_lock10_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue702_lock10_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue611_lock21_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue611_lock21_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue611_lock21_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue611_lock21_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue611_lock20_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue611_lock20_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue611_lock20_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_regression-issue611_lock20_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_v2_lock21_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_v2_lock21_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_v2_lock21_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_v2_lock21_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock20_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock20_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock20_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock20_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock20_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock20_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock20_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock20_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock11_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock11_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock11_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock11_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock11_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock11_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock11_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock11_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock10_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock10_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock10_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock10_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock10_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock10_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock10_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_private-packges_lock10_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_normalize-packagename_lock21_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_normalize-packagename_lock21_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_normalize-packagename_lock21_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_normalize-packagename_lock21_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_normalize-packagename_lock21_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_normalize-packagename_lock21_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_normalize-packagename_lock21_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_normalize-packagename_lock21_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_normalize-packagename_lock20_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_normalize-packagename_lock20_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_normalize-packagename_lock20_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_normalize-packagename_lock20_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_normalize-packagename_lock20_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_normalize-packagename_lock10_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_normalize-packagename_lock10_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_normalize-packagename_lock10_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_normalize-packagename_lock10_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_multi-constraint-deps_lock21_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_multi-constraint-deps_lock21_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_multi-constraint-deps_lock21_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_multi-constraint-deps_lock21_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_multi-constraint-deps_lock20_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_multi-constraint-deps_lock20_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_multi-constraint-deps_lock20_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_multi-constraint-deps_lock20_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_multi-constraint-deps_lock11_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_multi-constraint-deps_lock11_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_multi-constraint-deps_lock11_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_multi-constraint-deps_lock11_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock21_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock21_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock21_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock21_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock21_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock21_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock21_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock21_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock20_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock20_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock20_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock20_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock20_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock20_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock20_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock20_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock11_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock11_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock11_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock11_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock11_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock11_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock11_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock11_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock10_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock10_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock10_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock10_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock10_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock10_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock10_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_main-and-dev_lock10_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock21_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock21_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock21_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock21_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock21_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock21_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock21_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock21_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock20_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock20_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock20_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock20_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock20_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock20_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock20_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock20_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock11_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock11_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock11_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock11_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock11_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock11_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock11_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock11_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock10_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock10_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock10_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock10_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock10_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock10_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock10_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_local_lock10_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock21_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock21_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock21_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock21_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock21_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock21_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock21_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock21_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock20_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock20_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock20_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock20_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock20_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock20_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock20_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock20_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock11_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock11_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock11_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock11_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock11_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock11_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock11_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/plain_group-deps_lock11_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/only-groups_group-deps_lock21_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/only-groups_group-deps_lock21_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/only-groups_group-deps_lock21_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/only-groups_group-deps_lock21_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/only-groups_group-deps_lock20_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/only-groups_group-deps_lock20_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/only-groups_group-deps_lock20_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/only-groups_group-deps_lock20_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/only-groups_group-deps_lock11_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/only-groups_group-deps_lock11_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/only-groups_group-deps_lock11_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/only-groups_group-deps_lock11_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock21_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock21_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock21_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock21_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock21_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock21_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock21_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock21_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock20_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock20_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock20_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock20_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock20_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock20_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock20_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock20_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock11_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock11_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock11_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock11_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock11_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock11_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock11_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock11_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock10_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock10_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock10_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock10_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock10_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock10_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock10_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_main-and-dev_lock10_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock21_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock21_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock21_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock21_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock21_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock21_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock21_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock21_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock20_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock20_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock20_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock20_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock20_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock20_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock20_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock20_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock11_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock11_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock11_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock11_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock11_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock11_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock11_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/no-dev_group-deps_lock11_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock21_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock21_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock21_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock21_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock21_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock21_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock21_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock21_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock20_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock20_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock20_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock20_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock20_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock20_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock20_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock20_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock11_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock11_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock11_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock11_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock11_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock11_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock11_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock11_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock10_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock10_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock10_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock10_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock10_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock10_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock10_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/poetry/all-extras_with-extras_lock10_1.2.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/environment/plain_editable-self_1.5.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/environment/plain_editable-self_1.5.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/environment/plain_editable-self_1.4.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/environment/plain_editable-self_1.4.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/environment/plain_editable-self_1.3.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/environment/plain_editable-self_1.3.json.bin | Updated as part of this pull request. |
| tests/_data/snapshots/environment/plain_editable-self_1.2.xml.bin | Updated as part of this pull request. |
| tests/_data/snapshots/environment/plain_editable-self_1.2.json.bin | Updated as part of this pull request. |
Review details
Suppressed comments (2)
cyclonedx_py/_internal/utils/contact.py:77
Component.authorsnormalizes contacts into aSortedSet, but this helper counts the raw iterable. Duplicate manifest entries therefore become one structured author whilecontacts2author()sees two and clears the legacy field; for CycloneDX 1.2–1.5 that loses the author entirely. Deduplicate before checking the count.
cyclonedx_py/_internal/utils/contact.py:75- The email-only representation is documented as
"<email>", but the implementation returns the bare email string. Update the docstring so callers are not given an incorrect output contract.
- Files reviewed: 300/847 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| # this shape; treat it the same as "no usable name or email" rather than crash. | ||
| return None | ||
| name = m.group('name') or None | ||
| email = m.group('email') or None |
Comment on lines
+130
to
+132
| for name, email in addresses: | ||
| yield OrganizationalContact(name=name, email=email) | ||
| return |
jkowalleck
requested changes
Sep 7, 2026
jkowalleck
left a comment
jkowalleck
left a comment
Member
There was a problem hiding this comment.
Thank you for tackling this (draft!) PR.
I see a lot of arguable solutions here.
Let's discuss them in the respective ticket (not in this PR!)
| _PERSON_STRING_MATCHER = re_compile(r'^\s*(?P<name>[^<]*?)\s*(?:<(?P<email>[^<>]*)>)?\s*$') | ||
|
|
||
|
|
||
| def person_string2contact(value: str) -> Optional[OrganizationalContact]: |
Member
There was a problem hiding this comment.
why is this custom thing needed at all?
is it not as simple as
from email.utils import parseaddr
name, addr = parseaddr(text) if '@' in text else (text,'')| author = metadata.get('Author') | ||
| author_email = metadata.get('Author-email') | ||
| if author_email: | ||
| # `email.utils.getaddresses()` expects RFC 5322 address syntax. Fed something |
Member
There was a problem hiding this comment.
please remove those comments - they only describe how getaddresses works - that is already well documented in the respective library.
| if isinstance(author, str): | ||
| # Not per spec -- PEP 621 authors are tables, not strings -- but some | ||
| # real-world pyproject.toml files use Poetry's "Name <email>" convention | ||
| # here regardless. Be lenient and parse it the same way, rather than crash. |
Member
There was a problem hiding this comment.
nope. we will not be lenient here!
wrong format - info is dropped!
File is called "pip621" and docs say also...
Functionality related to PEP 621.
this thing shall implement the PEP621 only, not some "in the wild" observations.
| yield contact | ||
| continue | ||
| if not isinstance(author, dict): | ||
| # Not per spec at all -- e.g. `authors = [123]` -- TOML happily allows it, |
Member
There was a problem hiding this comment.
nope. we will not be lenient here!
wrong format - info is dropped!
File is called "pip621" and docs say also...
Functionality related to PEP 621.
this thing shall implement the PEP621 only, not some "in the wild" observations.
| # see https://python-poetry.org/docs/pyproject/#authors | ||
| for author in poetry.get('authors', ()): | ||
| if not isinstance(author, str): | ||
| # Not per spec -- Poetry's `authors` is a list of "Name <email>" strings -- |
Member
There was a problem hiding this comment.
Not per spec --
which spec?
anyway,just remove this comment. it has no value - it literally describes the code
| description=poetry.get('description'), | ||
| external_references=poetry2extrefs(poetry), | ||
| authors=authors, | ||
| author=contacts2author(authors), |
Member
There was a problem hiding this comment.
arguable - as described in the ticket for this PR.
see #648 (comment)
I'd rather go with ' & '.join(filter(lambda x: isInstance(x, str), poetry.authors))
| description=dist_meta['Summary'] if 'Summary' in dist_meta else None, | ||
| external_references=metadata2extrefs(dist_meta), | ||
| authors=authors, | ||
| author=contacts2author(authors), |
Member
There was a problem hiding this comment.
arguable - as described in the ticket for this PR.
see #648 (comment)
I'd rather go with ' & '.join(...))
| - https://packaging.python.org/en/latest/specifications/core-metadata/#author | ||
| - https://packaging.python.org/en/latest/specifications/core-metadata/#author-email | ||
|
|
||
| `Author` and `Author-email` are two independent free-text fields; there is no |
Member
There was a problem hiding this comment.
Author-email is no "free-text fields".
it si clearly specced: https://packaging.python.org/en/latest/specifications/core-metadata/#author-email
A string containing the author’s e-mail address. It can contain a name and e-mail address in the legal forms for a RFC-822 From: header.
| yield OrganizationalContact(name=name, email=email) | ||
| return | ||
| if author: | ||
| yield OrganizationalContact(name=author) |
Member
There was a problem hiding this comment.
how comes?
python packaging's 'author` clearly corresponds to CycloneDX's author - bot are arbitrary strings ...
jkowalleck
marked this pull request as draft
September 7, 2026 09:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Populates
component.authors(CycloneDX 1.6+, structured, repeatable) and derives the legacy singularcomponent.authorfor the single-author case, from three independent sources: PEP 621project.authors, Poetry'stool.poetry.authors, and packaging core-metadataAuthor/Author-email(wired into the environment scan).New shared helper module
cyclonedx_py/_internal/utils/contact.py:person_string2contact()parses the"Name <email>"convention used by both Poetry and packaging metadata.contacts2author()derives the legacyauthorstring only when there is exactly one author — CycloneDX has no agreed-upon way to fold multiple authors into one string (see CycloneDX/specification#335), so this deliberately does not guess a join convention and leaves it unset otherwise.Along the way, found and handled two real edge cases:
email.utils.getaddresses()silently mis-splits a bare name with no@on whitespace, keeping only the last word (getaddresses(['Jane Doe']) == [('', 'Jane')]).metadata2authors()filters out any parsed address that doesn't actually contain@before trusting it.authorsto be tables, buttests/_data/infiles/pipenv/no-deps/pyproject.tomlalready exercises the non-compliantauthors = ["Name <email>", ...]string form some real-world files use anyway —project2authors()now falls back to the same string parser instead of raising.56 new test cases across a new
test_utils_contact.py, newtest_utils_poetry.py, newtest_utils_packaging.py, and an extendedtest_utils_pep621.py. Full existing suite passes with only the expected snapshot updates (root components in fixtures that declare authors now show them).flake8/isort/mypyclean.Resolves or fixes issue: #648
AI Tool Disclosure
component.authors#648 as specified by the maintainer's own comments on the issue; add thorough test coverage; verify against the full existing test suite with no regressions.Affirmation
🤖 Generated with Claude Code