Skip to content

[WIP] tests: check all enum completeness#992

Draft
jkowalleck wants to merge 19 commits into
mainfrom
tests/check-all-enum-completeness
Draft

[WIP] tests: check all enum completeness#992
jkowalleck wants to merge 19 commits into
mainfrom
tests/check-all-enum-completeness

Conversation

@jkowalleck

Copy link
Copy Markdown
Member

Description

  • make sure all enums are tested for completeness
  • added test cases for all enums

Resolves or fixes issue: #991

AI Tool Disclosure

  • My contribution does not include any AI-generated content
  • My contribution includes AI-generated content, as disclosed below:
    • AI Tools: [e.g. GitHub CoPilot, ChatGPT, JetBrains Junie etc.]
    • LLMs and versions: [e.g. GPT-4.1, Claude Haiku 4.5, Gemini 2.5 Pro etc.]
    • Prompts: [Summarize the key prompts or instructions given to the AI tools]

Affirmation

@jkowalleck jkowalleck requested a review from a team as a code owner June 8, 2026 09:32
@codacy-production

codacy-production Bot commented Jun 8, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric Results
Complexity 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@read-the-docs-community

read-the-docs-community Bot commented Jun 8, 2026

Copy link
Copy Markdown

Comment thread tests/__init__.py
SNAPSHOTS_DIRECTORY = path.join(_TESTDATA_DIRECTORY, 'snapshots')

RECREATE_SNAPSHOTS = '1' == getenv('CDX_TEST_RECREATE_SNAPSHOTS')
RECREATE_SNAPSHOTS = True or '1' == getenv('CDX_TEST_RECREATE_SNAPSHOTS')

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗ revert

@jkowalleck jkowalleck marked this pull request as draft June 9, 2026 13:14
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
@jkowalleck jkowalleck force-pushed the tests/check-all-enum-completeness branch from ed7563b to 4ff6db8 Compare June 15, 2026 08:58
Comment thread tests/test_enums.py Dismissed
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Comment thread cyclonedx/model/crypto.py

@serializable.serializable_enum
class CryptoPrimitive(str, Enum):
# TODO: rename to `CryptoAlgorithmPrimitive`

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗ TODO

Comment thread cyclonedx/model/crypto.py
SIGNATURE = 'signature'
STREAM_CIPHER = 'stream-cipher'
XOF = 'xof'
# TODO: add `key-wrap` - since CDX1.7key-wrap

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗ TODO

Comment thread cyclonedx/model/crypto.py
ARMV9_A = 'armv9-a'
ARMV9_M = 'armv9-m'
GENERIC = 'generic'
GENERIC = 'generic' # TODO: move down

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗ TODO

Comment thread cyclonedx/model/crypto.py

@serializable.serializable_enum
class CryptoCertificationLevel(str, Enum):
# TODO: move to `CryptoAlgorithmCertificationLevel`

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗ TODO

Comment thread cyclonedx/model/crypto.py

@serializable.serializable_enum
class CryptoMode(str, Enum):
# TODO: rename to `CryptoAlgorithmMode`

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗ TODO

Comment thread cyclonedx/model/crypto.py

@serializable.serializable_enum
class CryptoImplementationPlatform(str, Enum):
# TODO: rename to `CryptoAlgorithmImplementationPlatform`

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗ TODO

Comment thread cyclonedx/model/crypto.py

@serializable.serializable_enum
class CryptoExecutionEnvironment(str, Enum):
# TODO: rename to `CryptoAlgorithmExecutionEnvironment`

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❗ TODO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant