Repository navigation
Conversation
Metadata.distributionConstraints (CycloneDX 1.7) is parsed from JSON and XML, but MetadataSerializer writes every metadata field by hand and had no case for it, so the TLP classification was dropped from every generated BOM. Re-generating the spec test file valid-metadata-distribution-1.7.json gave an empty metadata object. Write it after the properties, where the 1.7 XSD expects it, for the versions its @VersionFilter allows. Signed-off-by: Wleeaf <179125857+wleeaf@users.noreply.github.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metadata.distributionConstraints(CycloneDX 1.7) is parsed from both JSON and XML;JsonParserTestandXmlParserTestchecktlpisRED. ButMetadataSerializerwrites each metadata field by hand and has no case for it, so generators never write the field. Parsingvalid-metadata-distribution-1.7.jsonand generating 1.7 JSON gives:"metadata" : { }The XML output gives
<metadata/>. So the TLP classification is lost from every BOM the library writes.This writes
distributionConstraintsafterproperties, which is where the 1.7 XSD puts it in the metadata sequence. It is guarded byshouldSerializeField, so the field's@VersionFilter(Version.VERSION_17)still keeps it out of older versions.New tests:
schema17MetadataDistributionConstraintsJsonTestchecks that 1.7 JSON hasdistributionConstraints.tlpset toREDand that 1.6 JSON leaves it out.schema17MetadataDistributionConstraintsGenerationTestchecks that 1.7 XML has<tlp>RED</tlp>and passes the XSD.Both fail without the change and pass with it.
mvn -B testpasses: 1763 tests, 0 failures.