Repository navigation
Conversation
Standard.getLevels had no XML wrapper annotations, so the XML generator wrote each level as a <levels> element inside <levels>. The XSD expects <levels><level>, so re-generating the spec test file valid-standard-1.6.xml (or the JSON one) gave an invalid BOM. Annotate it like getRequirements and Level.getRequirements. Signed-off-by: Wleeaf <179125857+wleeaf@users.noreply.github.com>
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standard.getLevels()has no XML wrapper annotations, so the XML generator writes each level as a<levels>element inside the<levels>wrapper:The 1.6 and 1.7 XSDs expect
<levels><level>, so validation of the output fails withcvc-complex-type.2.4.a: Invalid content was found starting with element '{"http://cyclonedx.org/schema/bom/1.6":levels}'. One of '{"http://cyclonedx.org/schema/bom/1.6":level}' is expected.This happens whenvalid-standard-1.6.xmlorvalid-standard-1.6.json(and the 1.7 files) is parsed and XML is generated again.This annotates
getLevels()with@JacksonXmlElementWrapper(localName = "levels")and@JacksonXmlProperty(localName = "level"), the same waygetRequirements()andLevel.getRequirements()already are. JSON output is unchanged.schema16StandardLevelsGenerationTestgenerates XML from/1.6/valid-standard-1.6.xmland checks that it has<level bom-ref="level-1">and passes the XSD. It fails without the change and passes with it.mvn -B testpasses: 1762 tests, 0 failures.