fix: escape recording IDs in API paths to support special characters#192
Open
fvieira-alb wants to merge 1 commit intoCyCoreSystems:mainfrom
Open
fix: escape recording IDs in API paths to support special characters#192fvieira-alb wants to merge 1 commit intoCyCoreSystems:mainfrom
fvieira-alb wants to merge 1 commit intoCyCoreSystems:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds URL path escaping to the LiveRecording methods. Currently, the key.ID is being concatenated directly into the API endpoint strings. If a recording ID contains special characters (like slashes), the resulting URL becomes malformed, leading to 405 errors.
Changes:
Why this is necessary:
In many environments, recording names or IDs are dynamically generated and may contain characters that are not URL-safe. Using url.PathEscape ensures that the ARI (Asterisk REST Interface) receives the correct identifier regardless of its content, making the client more robust and preventing failed requests.
This change is