Overhaul, support abstract base classes for nodes, remove hardcoded valid node types#11
Merged
Overhaul, support abstract base classes for nodes, remove hardcoded valid node types#11
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
Collaborator
Author
|
fixed, also PLEASE SQUASH MERGE THIS |
Collaborator
Author
|
I tested with another plugin too and it works https://github.com/GrandtheUK/ResoniteCollectionsPlugin |
Collaborator
Author
|
Merged because I need this to start working on the audio node consolidation for Obsidian |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes the hardcoded list of valid node types, it can now work with any class which is detected as a node type (has a node attribute on it)
This means you can make abstract base classes for nodes now (yay for obsidian audio nodes)
The namespace of nodes doesn't matter anymore. The actual generated binding class will always have its namespace prefixed with "Bindings."
However now there needs to be a hardcoded list of additional using statements to add.
(Backwards compatibility has been added due to the bindings namespace change)
(Project Obsidian compiles with these changes and works)