feat: improve member query (CM-764)

[ulemons]

Query Optimization — Extracted Builder & Smarter Execution Paths

Summary

• Refactored queryMembersAdvanced to delegate SQL construction to a new queryBuilder module.
• Moved all complex query logic (filters, search, ordering, joins) into a dedicated builder for better maintainability and safer optimizations.
• Introduced specialized execution paths to improve performance for common scenarios.

---

Key Changes

• New module exports:
  • buildQuery — main data query supporting multiple optimized paths.
  • buildCountQuery — lightweight query for counting members, without unnecessary joins.
• Added member_search and member_orgs CTEs only when required.
• Introduced a clear and safe mapping for ORDER BY fields with sensible defaults.

---

Execution Paths in buildQuery

1️⃣ Direct ID Path (useDirectIdPath)

• filterString pins m.id to a single value or a small list (≤ ~100)
• Queries start directly from memberSegmentsAgg (msa)
• Minimal joins (members, optional member_orgs / memberEnrichments)

---

2️⃣ ActivityCount-Optimized Path

• Sorting by activityCount (or no explicit orderBy)
• No filters on me.*
• Builds a top_members CTE selecting best members by msa."activityCount" (with oversampling)
• This is the main optimization path — reduces load and latency for active-member views.

---

3️⃣ Generic Fallback Path

• Any other case (different sort, me.* filters, no aggregates, etc.)

---

Count Query

• buildCountQuery generates a minimal COUNT(DISTINCT m.id) query.
• Includes only the necessary joins and CTEs (msa, member_orgs, or member_search when relevant).

---

Why This Matters

• Performance: avoids unnecessary joins and top-N operations when IDs are pinned.
• Efficiency: pushes ranking to msa (indexed) and filters externally to keep pages filled.
• Maintainability: clear separation of query-building logic, easier to test and evolve.
• Safety: smart defaults and fallback paths prevent invalid SQL and keep ordering consistent.

---

Note

Refactors member querying to a new query builder with optimized execution paths and CTE-based search, plus utilities for org/segment enrichment.

• Members DAL (src/members)
  • Refactor queryMembersAdvanced: delegates SQL to buildQuery/buildCountQuery; parameterized CTE search via buildSearchCTE; logs constructed query; defaults orderBy to activityCount_DESC.
  • New utilities:
    • queryBuilder.ts: builds queries with three paths (direct ID, activityCount-optimized with top-N CTE, fallback); conditional CTEs/joins for member_search and member_orgs; safe ORDER BY mapping.
    • dataProcessor.ts: fetchOrganizationData, fetchSegmentData, and sortActiveOrganizations to enrich and order orgs/segments.
  • Data shaping: parallel fetching for organizations, identities, segments, and maintainers; simplified identity projection; optional inclusion of orgs/segments/maintainers respected.
  • Misc: switch to getServiceLogger; minor type tweaks; cleanup of column/field maps and constants.

^{Written by Cursor Bugbot for commit 6355108. This will update automatically on new commits. Configure here.}

[cursor]

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.