Rename AddProfileSource to AddCompletionClient#90
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the AI client/provider registration system in the
CrestApps.Core.AIlibrary, replacing the legacy "profile" terminology and APIs with a new, clearer "completion client" model. The changes affect both the implementation and documentation, improving consistency and paving the way for future extensibility.Key changes include:
API and Data Model Refactoring:
Replaces the obsolete
AIProfileProviderEntryand "profile source" registration with a newAICompletionClientEntryand "completion client" registration system, updating all relevant code, extension methods, and documentation to use the new terminology and data structures. (AIProfileProviderEntry.csremoved,AICompletionClientEntry.csadded,AIOptions.cs,ServiceCollectionExtensions.cs,architecture.md,ai-core.md) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Updates all AI provider registration helpers (Ollama, OpenAI, Azure OpenAI, Azure AI Inference) to use the new
AddCoreAICompletionClient<TClient>method instead of the oldAddCoreAIProfile<TClient>. (ServiceCollectionExtensions.csin each provider package) [1] [2] [3] [4]Documentation and Naming Consistency:
changelog/v1.0.0.md,ai-core.md,architecture.md) [1] [2] [3] [4] [5] [6]Testing:
AIOptions.CompletionClients. (AIProviderConnectionOptionsTests.cs) [1] [2]These changes modernize the AI provider registration approach, improve clarity for users and maintainers, and ensure a consistent, future-proof API surface.