Skip to content

Rename AddProfileSource to AddCompletionClient#90

Merged
MikeAlhayek merged 1 commit into
mainfrom
ma/rename
Jun 20, 2026
Merged

Rename AddProfileSource to AddCompletionClient#90
MikeAlhayek merged 1 commit into
mainfrom
ma/rename

Conversation

@MikeAlhayek

Copy link
Copy Markdown
Member

This pull request refactors the AI client/provider registration system in the CrestApps.Core.AI library, replacing the legacy "profile" terminology and APIs with a new, clearer "completion client" model. The changes affect both the implementation and documentation, improving consistency and paving the way for future extensibility.

Key changes include:

API and Data Model Refactoring:

  • Replaces the obsolete AIProfileProviderEntry and "profile source" registration with a new AICompletionClientEntry and "completion client" registration system, updating all relevant code, extension methods, and documentation to use the new terminology and data structures. (AIProfileProviderEntry.cs removed, AICompletionClientEntry.cs added, AIOptions.cs, ServiceCollectionExtensions.cs, architecture.md, ai-core.md) [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]

  • Updates all AI provider registration helpers (Ollama, OpenAI, Azure OpenAI, Azure AI Inference) to use the new AddCoreAICompletionClient<TClient> method instead of the old AddCoreAIProfile<TClient>. (ServiceCollectionExtensions.cs in each provider package) [1] [2] [3] [4]

Documentation and Naming Consistency:

  • Updates documentation and release notes to reflect the new "completion client" terminology, replacing all references to "profile" and "profile source" with "completion client" and "completion client entry". (changelog/v1.0.0.md, ai-core.md, architecture.md) [1] [2] [3] [4] [5] [6]

Testing:

  • Updates and extends tests to verify that completion clients are correctly registered and available through AIOptions.CompletionClients. (AIProviderConnectionOptionsTests.cs) [1] [2]

These changes modernize the AI provider registration approach, improve clarity for users and maintainers, and ensure a consistent, future-proof API surface.

@MikeAlhayek MikeAlhayek merged commit 6093950 into main Jun 20, 2026
10 checks passed
@MikeAlhayek MikeAlhayek deleted the ma/rename branch June 20, 2026 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant