Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ htmlcov
smartsim.egg-info
tests/test_output
.DS_Store
build

# Dependencies
smartsim/_core/.third-party
Expand Down
4 changes: 4 additions & 0 deletions doc/changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ To be released at some point in the future

Description

- Update install patch for PyTorch 2.7.1+rocm6.3
- Modernize typing syntax to Python 3.10+ standards
- Removed telemetry functionality, LaunchedManifest tracking
classes, and SmartDashboard integration
Expand All @@ -26,6 +27,9 @@ Description

Detailed Notes

- Updated the post-install patch which is applied to the Caffe2/PyTorch
CMakeFind module.
([SmartSim-PR793](https://github.com/CrayLabs/SmartSim/pull/793))
- Modernized typing syntax to use Python 3.10+ standards, replacing
`Union[X, Y]` with `X | Y`, `Optional[X]` with `X | None`, and generic
collections (`List[X]` → `list[X]`, `Dict[X, Y]` → `dict[X, Y]`, etc.).
Expand Down
6 changes: 3 additions & 3 deletions smartsim/_core/_install/configs/mlpackages/LinuxX64ROCM6.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,10 +30,10 @@
"replacement": "set_property(TARGET torch_c PROPERTY CXX_STANDARD 17)"
},
{
"description": "Fix Regex, Load HIP",
"description": "Fix LoadHIP.cmake regex to match tabs in ROCm version header",
"source_file": "../package/libtorch/share/cmake/Caffe2/public/LoadHIP.cmake",
"regex": ".*string.*",
"replacement": ""
"regex": "\\[ \\]\\+",
"replacement": "[ \\\\t]+"
},
{
"description": "Replace `/opt/rocm` with `$ENV{ROCM_PATH}`",
Expand Down