Update LogService class in CppMicroServices#1009
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
architapruthi
marked this pull request as draft
May 28, 2024 10:31
kkumar45
reviewed
May 31, 2024
kkumar45
reviewed
May 31, 2024
kkumar45
reviewed
May 31, 2024
jeffdiclemente
marked this pull request as ready for review
June 5, 2024 11:27
carneyweb
requested changes
Jun 6, 2024
jeffdiclemente
requested changes
Jun 14, 2024
tcormackMW
reviewed
Jun 14, 2024
jeffdiclemente
requested changes
Jun 17, 2024
added 2 commits
June 18, 2024 16:37
jeffdiclemente
requested review from
carneyweb,
jeffdiclemente,
kkumar45 and
tcormackMW
June 26, 2024 10:53
jeffdiclemente
requested changes
Jun 26, 2024
added 3 commits
July 17, 2024 10:14
jeffdiclemente
requested changes
Jul 17, 2024
jeffdiclemente
requested changes
Jul 18, 2024
added 2 commits
July 22, 2024 11:51
BrianWeed
reviewed
Jul 26, 2024
jeffdiclemente
approved these changes
Jul 31, 2024
tcormackMW
reviewed
Jul 31, 2024
tcormackMW
reviewed
Aug 1, 2024
jeffdiclemente
approved these changes
Aug 5, 2024
Member
|
@carneyweb, it looks like merging this PR is blocked by your review. Can you please re-review and either approve or provide feedback? Thanks. |
carneyweb
approved these changes
Sep 9, 2024
Contributor
|
Sorry for the delay. Looks good.
- Mike.
…On Sep 5, 2024 at 8:45 AM -0400, Jeff DiClemente ***@***.***>, wrote:
@carneyweb, it looks like merging this PR is blocked by your review. Can you please re-review and either approve or provide feedback? Thanks.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
RobertLauferElektrobit
pushed a commit
to insi-eb/CppMicroServices-cpp14
that referenced
this pull request
Jul 25, 2025
* Update LogService class --------- Co-authored-by: Archita P <architap@mathworks.com>
jeffdiclemente
pushed a commit
that referenced
this pull request
Jul 25, 2025
* Update LogService class in CppMicroServices (#1009) * Update LogService class --------- Co-authored-by: Archita P <architap@mathworks.com> * adapt for C++14 --------- Co-authored-by: architapruthi <architapruthi92@gmail.com> Co-authored-by: Archita P <architap@mathworks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current CppMicroServices LogService API and implementation that we ship with CppMicroServices does not confirm to the latest LogService OSGi spec (https://docs.osgi.org/specification/osgi.core/8.0.0/service.log.html).
Hence, to support latest features and classes, we are updating LogService class, which confirms to OSGi spec 8.
More information can be found out in the following RFC:
CppMicroServices/rfcs#21
Signed-off-by: The MathWorks, Inc.
architap@mathworks.com